[stable/gangway] add logic for applying env vars and pod annotations #20486

cten · 2020-02-01T03:42:22Z

…tations

Signed-off-by: cten cxtenberge5@gmail.com

What this PR does / why we need it:

I needed to pass pod annotations and environment variables to the pod. This allows for loading secrets from env.

Which issue this PR fixes

I don't believe there is a ticket at this time

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

DCO signed
Chart Version bumped
Variables are documented in the README.md
Title of the PR starts with chart name (e.g. [stable/mychartname])

@rk295

…tations Signed-off-by: cten <cxtenberge5@gmail.com>

k8s-ci-robot · 2020-02-01T03:42:37Z

Hi @cten. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zanhsieh · 2020-02-27T01:32:22Z

/ok-to-test

Signed-off-by: cten <cxtenberge5@gmail.com>

cten · 2020-03-05T17:01:34Z

Any maintainers have time to help me merge this? Thanks

cten · 2020-03-19T14:20:44Z

Ping...

rk295 · 2020-03-19T14:22:50Z

/lgtm

k8s-ci-robot · 2020-03-19T14:22:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cten, rk295

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~stable/gangway/OWNERS~~ [rk295]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rk295 · 2020-03-19T14:23:10Z

sorry for lag, things bit crazy atm!

cten · 2020-03-19T14:28:22Z

Thanks! Completely understand.

…elm#20486) * Added logic to allow loading secrets from ENV Vars and apply pod annotations Signed-off-by: cten <cxtenberge5@gmail.com> * Added logic to allow loading secrets from ENV Vars and apply pod annotations Signed-off-by: cten <cxtenberge5@gmail.com> * Bumped version Signed-off-by: cten <cxtenberge5@gmail.com>

rustycl0ck

The default installation of this chart is now broken.
EDIT: This is all good, I was trying to install with env: [] instead of env: {}

stable/gangway/templates/key.yaml

@@ -1,3 +1,4 @@
+{{- if not .Values.env.GANGWAY_SESSION_SECURITY_KEY -}}


…elm#20486) * Added logic to allow loading secrets from ENV Vars and apply pod annotations Signed-off-by: cten <cxtenberge5@gmail.com> * Added logic to allow loading secrets from ENV Vars and apply pod annotations Signed-off-by: cten <cxtenberge5@gmail.com> * Bumped version Signed-off-by: cten <cxtenberge5@gmail.com>

…elm#20486) * Added logic to allow loading secrets from ENV Vars and apply pod annotations Signed-off-by: cten <cxtenberge5@gmail.com> * Added logic to allow loading secrets from ENV Vars and apply pod annotations Signed-off-by: cten <cxtenberge5@gmail.com> * Bumped version Signed-off-by: cten <cxtenberge5@gmail.com> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>

…elm#20486) * Added logic to allow loading secrets from ENV Vars and apply pod annotations Signed-off-by: cten <cxtenberge5@gmail.com> * Added logic to allow loading secrets from ENV Vars and apply pod annotations Signed-off-by: cten <cxtenberge5@gmail.com> * Bumped version Signed-off-by: cten <cxtenberge5@gmail.com> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>

cten added 3 commits January 31, 2020 22:25

Added logic to allow loading secrets from ENV Vars and apply pod anno…

3818b66

…tations Signed-off-by: cten <cxtenberge5@gmail.com>

Added logic to allow loading secrets from ENV Vars and apply pod anno…

4078391

…tations Signed-off-by: cten <cxtenberge5@gmail.com>

Merge branch 'master' of https://github.com/cten/charts

7121c17

helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2020

k8s-ci-robot requested review from rk295 and unguiculus February 1, 2020 03:42

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 1, 2020

k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2020

helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Feb 27, 2020

cten force-pushed the master branch from d98f180 to 7121c17 Compare February 27, 2020 04:00

helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Feb 27, 2020

cten force-pushed the master branch from f90c92a to f33a849 Compare February 27, 2020 04:14

Bumped version

e4f93ef

Signed-off-by: cten <cxtenberge5@gmail.com>

cten force-pushed the master branch from dca8c9d to e4f93ef Compare February 27, 2020 04:33

helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Feb 27, 2020

Merge branch 'master' into master

6c1665d

Signed-off-by: cten <cxtenberge5@gmail.com>

cten force-pushed the master branch from 00b16d3 to 6c1665d Compare February 27, 2020 04:43

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020

k8s-ci-robot merged commit a02aba2 into helm:master Mar 19, 2020

PixelJonas mentioned this pull request Mar 25, 2020

[stable/gangway] - add option to extend env #21160

Closed

4 tasks

rustycl0ck reviewed Jun 4, 2020

View reviewed changes

stable/gangway/templates/key.yaml

@@ -1,3 +1,4 @@

{{- if not .Values.env.GANGWAY_SESSION_SECURITY_KEY -}}

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable/gangway] add logic for applying env vars and pod annotations #20486

[stable/gangway] add logic for applying env vars and pod annotations #20486

cten commented Feb 1, 2020

k8s-ci-robot commented Feb 1, 2020

zanhsieh commented Feb 27, 2020

cten commented Mar 5, 2020

cten commented Mar 19, 2020

rk295 commented Mar 19, 2020

k8s-ci-robot commented Mar 19, 2020

rk295 commented Mar 19, 2020

cten commented Mar 19, 2020

rustycl0ck left a comment •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

		@@ -1,3 +1,4 @@
		{{- if not .Values.env.GANGWAY_SESSION_SECURITY_KEY -}}

[stable/gangway] add logic for applying env vars and pod annotations #20486

[stable/gangway] add logic for applying env vars and pod annotations #20486

Conversation

cten commented Feb 1, 2020

What this PR does / why we need it:

Which issue this PR fixes

Checklist

k8s-ci-robot commented Feb 1, 2020

zanhsieh commented Feb 27, 2020

cten commented Mar 5, 2020

cten commented Mar 19, 2020

rk295 commented Mar 19, 2020

k8s-ci-robot commented Mar 19, 2020

rk295 commented Mar 19, 2020

cten commented Mar 19, 2020

rustycl0ck left a comment • edited Loading

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

rustycl0ck left a comment •

edited

Loading