This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/coredns] Allow to specify a PodDisruptionBudget #20586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/M
k8s-ci-robot
added
the
approved
helm-bot
added
the
Contribution Allowed
|
@Smirl fyi since you were interested in that as well. |
Smirl
approved these changes
Feb 6, 2020
| k8s-app: {{ .Chart.Name | quote }} | ||
| {{- end }} | ||
| app.kubernetes.io/name: {{ template "coredns.name" . }} | ||
| {{ toYaml .Values.podDisruptionBudget | indent 2 }} |
There was a problem hiding this comment.
There are only 2 fields. I would perhaps add minAvailable and maxUnavailable to values. Both way work though.
There was a problem hiding this comment.
I didn't include the fields to match with the other pdb in the Repo. I'd leave it like that
There was a problem hiding this comment.
Cool. Looks good to me. But I can't /approve 😿
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
|
@acaleph |
cpanato
suggested changes
Feb 26, 2020
helm-bot
removed
the
Contribution Allowed
|
@mrueg please sing the DCO |
Yes shouldn't have used the github UI. :( Will repush. |
Co-Authored-By: Carlos Tadeu Panato Junior <ctadeu@gmail.com> Signed-off-by: Manuel Rüger <manuel@rueg.eu>
helm-bot
added
the
Contribution Allowed
|
@cpanato pushed again with DCO signed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks, appreciated! @cpanato |
Hakob
pushed a commit
to Hakob/charts
that referenced
this pull request
Feb 26, 2020
* [stable/coredns] Allow to specify a PodDisruptionBudget Signed-off-by: Manuel Rüger <manuel@rueg.eu> * Update stable/coredns/Chart.yaml Co-Authored-By: Carlos Tadeu Panato Junior <ctadeu@gmail.com> Signed-off-by: Manuel Rüger <manuel@rueg.eu> Co-authored-by: Carlos Tadeu Panato Junior <ctadeu@gmail.com> Signed-off-by: Hakob Arakelyan <hakoaraqelyan@gmail.com>
4 tasks
irlevesque
pushed a commit
to quantopian/charts
that referenced
this pull request
Jul 13, 2020
* [stable/coredns] Allow to specify a PodDisruptionBudget Signed-off-by: Manuel Rüger <manuel@rueg.eu> * Update stable/coredns/Chart.yaml Co-Authored-By: Carlos Tadeu Panato Junior <ctadeu@gmail.com> Signed-off-by: Manuel Rüger <manuel@rueg.eu> Co-authored-by: Carlos Tadeu Panato Junior <ctadeu@gmail.com>
includerandom
pushed a commit
to includerandom/helm_charts
that referenced
this pull request
Jul 19, 2020
* [stable/coredns] Allow to specify a PodDisruptionBudget Signed-off-by: Manuel Rüger <manuel@rueg.eu> * Update stable/coredns/Chart.yaml Co-Authored-By: Carlos Tadeu Panato Junior <ctadeu@gmail.com> Signed-off-by: Manuel Rüger <manuel@rueg.eu> Co-authored-by: Carlos Tadeu Panato Junior <ctadeu@gmail.com>
li-adrienloiseau
pushed a commit
to li-adrienloiseau/charts
that referenced
this pull request
Jul 29, 2020
* [stable/coredns] Allow to specify a PodDisruptionBudget Signed-off-by: Manuel Rüger <manuel@rueg.eu> * Update stable/coredns/Chart.yaml Co-Authored-By: Carlos Tadeu Panato Junior <ctadeu@gmail.com> Signed-off-by: Manuel Rüger <manuel@rueg.eu> Co-authored-by: Carlos Tadeu Panato Junior <ctadeu@gmail.com> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh
pushed a commit
to mmingorance-dh/charts
that referenced
this pull request
Aug 28, 2020
* [stable/coredns] Allow to specify a PodDisruptionBudget Signed-off-by: Manuel Rüger <manuel@rueg.eu> * Update stable/coredns/Chart.yaml Co-Authored-By: Carlos Tadeu Panato Junior <ctadeu@gmail.com> Signed-off-by: Manuel Rüger <manuel@rueg.eu> Co-authored-by: Carlos Tadeu Panato Junior <ctadeu@gmail.com> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No
What this PR does / why we need it:
Adds optional PodDisruptionBudget
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])