Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nginx-ingress] Bump nginx-ingress version to 0.29.0 #20813

Merged
merged 2 commits into from
Feb 18, 2020
Merged

[stable/nginx-ingress] Bump nginx-ingress version to 0.29.0 #20813

merged 2 commits into from
Feb 18, 2020

Conversation

Vlatombe
Copy link
Contributor

@Vlatombe Vlatombe commented Feb 17, 2020 •
edited
Loading

What this PR does / why we need it:

Bump nginx-ingress version to 0.29.0

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@Vlatombe
[stable/nginx-ingress] Bump nginx-ingress version to 0.29.0
d095738 
Signed-off-by: Vincent Latombe <vincent@latombe.net>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Vlatombe. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ChiefAlexander
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2020
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Feb 18, 2020
@Vlatombe
Bump minor version
9bdd2ed 
Signed-off-by: Vincent Latombe <vincent@latombe.net>
@Vlatombe Vlatombe force-pushed the nginx-ingress-0.29.0 branch from 13d9b95 to 9bdd2ed Compare February 18, 2020 14:21
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Feb 18, 2020
@ChiefAlexander
Copy link
Collaborator

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChiefAlexander, Vlatombe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit bbd5a0c into helm:master Feb 18, 2020
bharathkkb pushed a commit to bharathkkb/charts that referenced this pull request Feb 18, 2020
@Vlatombe @bharathkkb
[stable/nginx-ingress] Bump nginx-ingress version to 0.29.0 (helm#20813)
c93eddc 
* [stable/nginx-ingress] Bump nginx-ingress version to 0.29.0

Signed-off-by: Vincent Latombe <vincent@latombe.net>

* Bump minor version

Signed-off-by: Vincent Latombe <vincent@latombe.net>
Signed-off-by: bharathkkb <bharathkrishnakb@gmail.com>
@travisgroth travisgroth mentioned this pull request Feb 20, 2020
Closed
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@Vlatombe @li-adrienloiseau
[stable/nginx-ingress] Bump nginx-ingress version to 0.29.0 (helm#20813)
d55b479 
* [stable/nginx-ingress] Bump nginx-ingress version to 0.29.0

Signed-off-by: Vincent Latombe <vincent@latombe.net>

* Bump minor version

Signed-off-by: Vincent Latombe <vincent@latombe.net>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@Vlatombe
[stable/nginx-ingress] Bump nginx-ingress version to 0.29.0 (helm#20813)
24b2162 
* [stable/nginx-ingress] Bump nginx-ingress version to 0.29.0

Signed-off-by: Vincent Latombe <vincent@latombe.net>

* Bump minor version

Signed-off-by: Vincent Latombe <vincent@latombe.net>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChiefAlexander ChiefAlexander ChiefAlexander left review comments

@taharah taharah Awaiting requested review from taharah

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vlatombe @k8s-ci-robot @ChiefAlexander @helm-bot