[stable/metrics-server] Update rbac apiversion from v1beta1 to v1

[mtougeron]

Signed-off-by: Mike Tougeron tougeron@adobe.com

What this PR does / why we need it:

This updates the rbac apiVersion from v1beta1 to v1. Other areas of the chart are already using v1

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Title of the PR starts with chart name (e.g. [stable/mychartname])

[k8s-ci-robot]

Hi @mtougeron. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mtougeron]

cc @olemarkus / @kennethaasan

[olemarkus]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtougeron, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/metrics-server/OWNERS [olemarkus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mtougeron]

Thanks!

[kppullin]

I think this may have be a breaking change and adding a comment here in case someone else runs across the same trouble.

When updating from 2.10.0 to 2.10.1 using helm v3.1.0 we get the error:

Error: UPGRADE FAILED: rendered manifests contain a new resource that already exists. Unable to continue with update: existing resource conflict: namespace: kube-system, name: metrics-server-auth-reader, existing_kind: rbac.authorization.k8s.io/v1, Kind=RoleBinding, new_kind: rbac.authorization.k8s.io/v1, Kind=RoleBinding

which looks similar to the issues raised here: helm/helm#7697 (comment) . It's confusing that the existing_kind is listed as rbac.authorization.k8s.io/v1 since the existing value is rbac.authorization.k8s.io/v1beta1, however this aligns with most of the comments in the linked helm issue.

I've worked around it be deleting and recreating the chart, as suggested by the above thread.