-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/kube-slack] To run kube-slack as non root #21983
Conversation
Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@akelius.de>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pierluigilenoci The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @pierluigilenoci. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Previous PR #21967 |
/ok-to-test |
/assign @jstriebel |
/retest |
@@ -41,10 +43,6 @@ spec: | |||
- configMapRef: | |||
name: {{ template "kube-slack.fullname" . }} | |||
resources: | |||
{{ if .Values.image.pullSecret }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierluigilenoci This is undoing your changes from #21915, which is probably not intended. Maybe you just need to merge the upstream master branch from helm/charts
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is undoing my changes from #21915 on purpose because was useless and even a broken solution. This new PR is a better approach to solve the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Why exactly was it broken? In my opinion it would be better to fix the pullSecret usage, instead of removing it, since somebody else might still need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use my solution you get something like that
imagePullSecrets:
- name: yoursecret {}
with an extra {}
and I was not able to fix it because in this moment I don't have the time to eat my brain out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I preferred to remove it in favor of a solution that worked for what my needs were. That is to make this chart compatible with the pod security policy. Not the best solution ever but at least the chart is not broken.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. |
What this PR does / why we need it:
To run kube-slack as non root
Which issue this PR fixes
No issue to fix, only an improvement.
Special notes for your reviewer:
I had to delete my fork and recreate it, sorry for that.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)