Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/grafana] Template ingress annotations #22123

Merged

Conversation

steven-sheehy
Copy link
Collaborator

@steven-sheehy steven-sheehy commented Apr 25, 2020

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

No

What this PR does / why we need it:

  • Allows ingress annotations to be templated
  • Bumps Grafana version to 6.7.3

Use case:

Traefik requires the namespace to be included in the name of middleware that you want to associate with the ingress. For example if you had a middleware named the same as your chart:

ingress:
  enabled: true
  annotations:
    traefik.ingress.kubernetes.io/router.middlewares: '{{ include "mychart.namespace" . }}-{{ include "mychart.fullname" . }}@kubernetescrd'

Which issue this PR fixes

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Apr 25, 2020
@k8s-ci-robot k8s-ci-robot requested a review from zanhsieh April 25, 2020 03:25
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 25, 2020
@steven-sheehy
Copy link
Collaborator Author

/assign @zanhsieh
/assign @maorfr
/ok-to-test

@steven-sheehy
Copy link
Collaborator Author

/test pull-charts-e2e

@zanhsieh
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 25, 2020
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy force-pushed the grafana-templated-annotations branch from a2db9d4 to 6104bb7 Compare April 25, 2020 14:46
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2020
@steven-sheehy
Copy link
Collaborator Author

/test pull-charts-e2e

@steven-sheehy
Copy link
Collaborator Author

Tests seem to be flaky?
/test pull-charts-e2e

@zanhsieh
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steven-sheehy, zanhsieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zanhsieh
Copy link
Collaborator

/test pull-charts-e2e

1 similar comment
@steven-sheehy
Copy link
Collaborator Author

/test pull-charts-e2e

@steven-sheehy
Copy link
Collaborator Author

/test pull-charts-e2

@k8s-ci-robot
Copy link
Contributor

@steven-sheehy: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-charts-e2e

Use /test all to run all jobs.

In response to this:

/test pull-charts-e2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@steven-sheehy
Copy link
Collaborator Author

/test pull-charts-e2e

1 similar comment
@steven-sheehy
Copy link
Collaborator Author

/test pull-charts-e2e

@steven-sheehy
Copy link
Collaborator Author

Not sure why it's so flaky. Can't be my changes since ingress not enabled in any tests.
/test pull-charts-e2e

@k8s-ci-robot k8s-ci-robot merged commit 0b9b4c5 into helm:master Apr 26, 2020
@steven-sheehy steven-sheehy deleted the grafana-templated-annotations branch April 26, 2020 23:29
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants