-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/minio] Fix TLS can't be enabled #22470
Conversation
Hi @TreeKat71. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Muller Hsu <muller79924@gmail.com>
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nitisht, TreeKat71 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@capnajax you might have problems again after this has been merged, please check your SSL certs, etc. |
@@ -4,7 +4,7 @@ | |||
{{ $drivesPerNode := .Values.drivesPerNode | int }} | |||
{{ $scheme := "http" }} | |||
{{- if .Values.tls.enabled }} | |||
{{ $scheme := "https" }} | |||
{{ $scheme = "https" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got error on this change with helm v2.10
Error: parse error in "minio/templates/statefulset.yaml": template: minio/templates/statefulset.yaml:7: unexpected "=" in operand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the go version, please refer to helm/helm#4987
BTW, I use Helm 3
helm#22470) Signed-off-by: Muller Hsu <muller79924@gmail.com>
helm#22470) Signed-off-by: Muller Hsu <muller79924@gmail.com>
helm#22470) Signed-off-by: Muller Hsu <muller79924@gmail.com> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
helm#22470) Signed-off-by: Muller Hsu <muller79924@gmail.com> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
[fix] $scheme always "http"
The syntax is error, and it leads to $schema always be "http"
Is this a new chart
No
What this PR does / why we need it:
TLS can't be enabled successfully due to the go template in a wrong way.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
It has been corrected in #21373 and being wrong again in #21503.
Please check it, cause I use the latest helm chart and can't enable tls successfully.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)