Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[prometheus-operator] deprecate chart #23693

Closed
wants to merge 1 commit into from
Closed

[prometheus-operator] deprecate chart #23693

wants to merge 1 commit into from

Conversation

naseemkullah
Copy link
Collaborator

Signed-off-by: Naseem naseem@transit.app

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Naseem <naseem@transit.app>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: naseemkullah
To complete the pull request process, please assign bismarck
You can assign the PR to them by writing /assign @bismarck in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2020
@naseemkullah naseemkullah changed the title deprecate prom-operator [prometheus-operator] deprecate chart Sep 5, 2020
@scottrigby
Copy link
Member

/hold

For this one, let's wait until prometheus-community/helm-charts#1 is complete. Tomorrow most likely 🙂

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2020
@k8s-ci-robot
Copy link
Contributor

@naseemkullah: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-charts-e2e 381a8af link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@scottrigby
Copy link
Member

@naseemkullah I had already forgotten about this PR in the 15 years that passed since you opened it 😂 I'll close it now in favor of #23738 since it's already in e2e/tide process.

@scottrigby scottrigby closed this Sep 9, 2020
@naseemkullah naseemkullah deleted the deprecate-prom-operator branch September 9, 2020 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants