-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Conversation
@compleatang thanks for looking to promote this to stable. We recently documented the process to do so. Could you make sure this PR meets with the guidelines at https://github.com/kubernetes/charts/blob/master/PROCESSES.md#promoting-a-chart-from-incubator-to-stable |
@mattfarina Sorry I had missed that. Should comply with the guidelines now. |
/ok-to-test |
@mattfarina any movement here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add deprecation note to readme of deprecated chart.
See https://github.com/kubernetes/charts/blob/master/PROCESSES.md#deprecating-a-chart
appVersion: 0.17.1 | ||
deprecated: true # moved to stable | ||
description: Burrow is a permissionable smart contract machine | ||
icon: https://pbs.twimg.com/profile_images/697035383679295488/_6vl74tM_400x400.png | ||
keywords: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove maintainers from deprecated chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a note to NOTES.txt
as well.
incubator/burrow/README.md
Outdated
@@ -2,6 +2,8 @@ | |||
|
|||
[burrow](https://github.com/hyperledger/burrow) is a permissioned Ethereum smart-contract blockchain node. It executes Ethereum smart contract code on a permissioned virtual machine. Burrow provides transaction finality and high transaction throughput on a proof-of-stake Tendermint consensus engine. | |||
|
|||
**Note** this repository has been [moved to stable](../../stable/burrow). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mention explicitly that the chart (not the repo) has been deprecated. Here's an example:
https://github.com/kubernetes/charts/blob/5e8a4639e05c3e6f4c9765881b0b26f97e12e098/incubator/oauth-proxy/README.md#L5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Changed it now. It would be good to document this process with a bit more particularity to save the back and forth.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: compleatang, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* upstream/master: (944 commits) Rename service port to http (helm#4442) [stable/neo4j] Change the image of the initContainer examples (helm#4269) move burrow to stable repo (helm#3481) Upgrade kube-state-metrics to 1.2.0, add new collectors (helm#4146) Add review guidelines around pvcs (helm#4223) [stable/parse] Release 0.3.10 (helm#4389) [stable/phabricator] Release 0.5.19 (helm#4433) Support exposing jmx and additional ports (helm#4072) Add default of "" for string comparison (helm#4420) [incubator/kafka] Makes readiness probe configurable (helm#3948) Published stash chart 0.7.0-rc.1 (helm#4410) Enable testing charts with test values (helm#4157) [incubator/kafka] Fix initContainer failure which did not error (helm#4400) [stable/etcd-operator] deployment typos and add tolerations (helm#4139) Typo fix in coscale/README.md (helm#4306) Typo fix in concourse/README.md (helm#4303) Typo fix in cockroachdb/README.md (helm#4302) [stable/jenkins] Bump appVersion (helm#4177) Typo fix in cluster-autoscaler/README.md (helm#4301) [stable/traefik] Bump appVersion to 1.5.4 (helm#4206) ...
Signed-off-by: voron <av@arilot.com>
Graduates Burrow to stable repository.