consul - add readiness probe #56
Conversation
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
|
ok to test |
| @@ -157,6 +157,12 @@ spec: | |||
| - name: gossip-key | |||
| secret: | |||
| secretName: gossip-key | |||
| readinessProbe: | |||
| httpGet: | |||
| path: /v1/health/service/consul | |||
There was a problem hiding this comment.
Dumb question. Does this work with clustered consul? With the master when it was in boostrap mode, we had issues with the readinessProbe working.
There was a problem hiding this comment.
@chrislovecnm - It should work and always return details of the servers in the cluster. I haven't had an issue where it hasn't worked using this chart. Have you? Is there another endpoint that would better server as readinessProbe?
There was a problem hiding this comment.
yah we have had a problem with that endpoint, when using DNS names for discovery.
There was a problem hiding this comment.
Okay thanks. I'll take a look at polling another endpoint. Do you have any suggestions?
There was a problem hiding this comment.
We did a netstat to see if Consul was listening to the port, but maybe it is the way we set it up. I don't personally like the netstat either. I will take it out for a test drive when I have a chance. But if it is working for you, we can iterate on it in incubator.
|
I think this is GTG. LMK if anything else is outstanding. |
|
@viglesiasce LGTM ... How about u? |
|
LGTM |
Added readiness prod to deployment spec