This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[incubator/kube-spot-termination-notice-handler] Add Support for Tolerations #5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
…rations - Add tolerations section to daemonset template - Add tolerations section to values file (with example configs)
stevenpall
force-pushed
the
kube-spot-termination-notice-handler-tolerations
branch
from
b95e6af to
c57ffc0
Compare
|
/assign @sameersbn |
unguiculus
suggested changes
Jul 1, 2018
| - {{- range $key, $value := .Values.tolerations }} | ||
| {{- end }} | ||
| {{ toYaml .Values.tolerations | indent 8 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Please change as follows:
{{- if .Values.tolerations }}
tolerations:
{{ toYaml .Values.tolerations | indent 8 }}
{{- end }}| @@ -40,3 +40,9 @@ serviceAccount: | |||
| # The name of the service account to use. | |||
| # If not set and create is true, a name is generated using the fullname template | |||
| name: | |||
|
|
|||
| tolerations: {} | |||
| @@ -1,7 +1,7 @@ | |||
| apiVersion: v1 | |||
| description: Watch and action AWS spot termination events | |||
| name: kube-spot-termination-notice-handler | |||
| version: 0.2.1 | |||
| version: 0.2.2 | |||
There was a problem hiding this comment.
Bump minor version for a new feature.
|
/assign |
|
@unguiculus Let me know if that looks good now! |
unguiculus
approved these changes
Jul 15, 2018
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevenpall, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
NicolasT
added a commit
to scality/charts
that referenced
this pull request
Jul 15, 2018
…labels * kubernetes/master: (411 commits) [stable/efs-provisioner] Chart for efs-provisioner, a Kubernetes external-storage provisioner (helm#3233) [stable/filebeat] filebeat fixes (helm#6332) [stable/stolon] Add support for priorityClasses (helm#6607) [stable/external-dns] Add support for priorityClasses (helm#6606) [stable/minio] Add support for priorityClasses (helm#6604) [stable/cluster-autoscaler] Add support for priorityClasses (helm#6603) [stable/oauth2-proxy] Add support for priorityClasses (helm#6586) [stable/elasticsearch-exporter] add support for priorityClasses (helm#6584) [stable/traefik] adding support for traefik wildcard certificates (helm#6015) gcloud-sqlproxy: add tolerations and affinity to the Deployment (helm#6495) Review readme (helm#6399) [stable/mongodb-replicaset] Prometheus Metrics export (helm#6282) [stable/artifactory-ha] Typo fix: livessProbed->livenessProbed (helm#6462) [stable/artifactory] livessProbed->livenessProbed (helm#6461) [incubator/kube-spot-termination-notice-handler] Add Support for Tolerations (helm#5813) [stable/kanister-operator] RBAC changes and kanister profile creation (helm#6280) fix redis-ha NOTE.txt, stable/redis-ha don't create master-0 pod (helm#6131) [stable/concourse] add support for custom envvars for the web containers (helm#6441) upgrade to latest prometheus release 2.3.2 and alertmanager 0.15.1 (helm#6623) cert-manager: fast-forward to upstream 777ce6f4 (helm#6625) ...
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
…rations (helm#5813) * [incubator/kube-spot-termination-notice-handler] Add Support for Tolerations - Add tolerations section to daemonset template - Add tolerations section to values file (with example configs) * Make requested changes * Update Chart.yaml Signed-off-by: Jakob Niggel <info@jakobniggel.de>
gsemet
pushed a commit
to gsemet/charts
that referenced
this pull request
Nov 13, 2018
…rations (helm#5813) * [incubator/kube-spot-termination-notice-handler] Add Support for Tolerations - Add tolerations section to daemonset template - Add tolerations section to values file (with example configs) * Make requested changes * Update Chart.yaml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
Special notes for your reviewer: