Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-blackbox-exporter] values.yaml: Added missing 'modu… #6621

Closed
wants to merge 1 commit into from
Closed

[stable/prometheus-blackbox-exporter] values.yaml: Added missing 'modu… #6621

wants to merge 1 commit into from

Conversation

jpds
Copy link
Collaborator

@jpds jpds commented Jul 12, 2018

What this PR does / why we need it: Example configuration is missing the modules keyword.

@gianrubio

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2018
@k8s-ci-robot k8s-ci-robot requested review from linki and scottrigby July 12, 2018 11:15
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 12, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @jpds. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jpds
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: prydonius

If they are not already assigned, you can assign the PR to them by writing /assign @prydonius in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpds jpds changed the title [stable/prometheus-blackbox-example] values.yaml: Added missing 'modu… [stable/prometheus-blackbox-exporter] values.yaml: Added missing 'modu… Jul 12, 2018

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…ules' keyword to example config.
@stale
Copy link

stale bot commented Aug 18, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2018
@mattfarina mattfarina added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2018
@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 27, 2018
@jpds
Copy link
Collaborator Author

jpds commented Sep 7, 2018

Already fixed by #6399.

@jpds jpds closed this Sep 7, 2018
@jpds jpds deleted the fix-blackbox-config-example branch September 7, 2018 16:46
@ey-bot ey-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants