This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[Documentation] Add HPA best practices to review guidelines. #7562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After reviewing the nginx-ingress and spark charts which both have HPA's defined I am making the following recommendations based on the nginx-ingress chart specifically (after helm#7560) be added to the review guidelines. Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
k8s-ci-robot
added
the
approved
ey-bot
added
the
Contribution Allowed
scottrigby
suggested changes
Sep 6, 2018
REVIEW_GUIDELINES.md
Outdated
| @@ -112,32 +112,51 @@ volumes: | |||
| {{- end -}} | |||
| ``` | |||
|
|
|||
| * Example pvc.yaml | |||
| ## AutoScaling / HorizontalPodAutoscaler | |||
There was a problem hiding this comment.
@paulczar The autoscaling addition looks good 👍 But did you mean to delete the example PVC YAML?
There was a problem hiding this comment.
lulz wtf how did I manage that. I can't even copy and paste good!
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
ey-bot
added
the
Contribution Allowed
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulczar, scottrigby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ey-bot
added
the
Contribution Allowed
jicowan
pushed a commit
to jicowan/charts
that referenced
this pull request
Oct 2, 2018
* [Documentation] Add HPA best practices to review guidelines. After reviewing the nginx-ingress and spark charts which both have HPA's defined I am making the following recommendations based on the nginx-ingress chart specifically (after helm#7560) be added to the review guidelines. Signed-off-by: Paul Czarkowski <username.taken@gmail.com> * fixed accidental deletion of pvc.yaml Signed-off-by: Paul Czarkowski <username.taken@gmail.com> Signed-off-by: jenkin-x <jicowan@hotmail.com>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
* [Documentation] Add HPA best practices to review guidelines. After reviewing the nginx-ingress and spark charts which both have HPA's defined I am making the following recommendations based on the nginx-ingress chart specifically (after helm#7560) be added to the review guidelines. Signed-off-by: Paul Czarkowski <username.taken@gmail.com> * fixed accidental deletion of pvc.yaml Signed-off-by: Paul Czarkowski <username.taken@gmail.com> Signed-off-by: Jakob Niggel <info@jakobniggel.de>
|
So I am working on helm/helm#5110, where an hpa template is generated with the |
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing the nginx-ingress and spark charts which both have HPA's
defined I am making the following recommendations based on the
nginx-ingress chart specifically (after #7560) be added to the
review guidelines.
Signed-off-by: Paul Czarkowski username.taken@gmail.com