Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Adding existing secret #9532

Closed
wants to merge 1 commit into from

Conversation

cliedeman
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • [ x] Variables are documented in the README.md

@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cliedeman
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: desaintmartin

If they are not already assigned, you can assign the PR to them by writing /assign @desaintmartin in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: cliedeman <ciaranliedeman@gmail.com>
@cliedeman cliedeman force-pushed the postgresql/existingSecret branch from 55501f8 to 861818f Compare November 25, 2018 12:16
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2018
@carrodher
Copy link
Collaborator

Can you resolve the existing conflicts before continue?

@yeahphil
Copy link
Contributor

yeahphil commented Dec 4, 2018

Aside from the conflicts, this PR is incomplete. It doesn't change the secretKeyRefs in the chart, so rather than allow specifying a secret name, existingSecret is effectively just a flag that prevents creating a secret for the password.

That will work, but only if there's a secret with the name the chart would have used if existingSecret wasn't set (i.e. the output of template "postgresql.fullname" .).

I put together a PR that respects the value of existingSecret here: #9729

@cliedeman
Copy link
Contributor Author

@yeahphil Thanks, I did that when I added this feature originally to the chart forgot to do it here.

@cliedeman cliedeman closed this Dec 4, 2018
@yeahphil
Copy link
Contributor

yeahphil commented Dec 5, 2018

@cliedeman thank you for the original work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants