Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to test docs becomes Japanese #773

Closed
lindhe opened this issue Aug 17, 2020 · 1 comment · Fixed by #774
Closed

Link to test docs becomes Japanese #773

lindhe opened this issue Aug 17, 2020 · 1 comment · Fixed by #774
Labels
bug

Comments

@lindhe
Copy link
Contributor

lindhe commented Aug 17, 2020

For me, the "(view test docs)" link on this page leads me to the Japanese page instead of the English page.

But it seems fine in the markdown...

helm-www/content/en/docs/topics/charts_hooks.md

Line 35 in 4395c5f

| `test` | Executes when the Helm test subcommand is invoked ([view test docs](/docs/chart_tests/)) |

@mattfarina mattfarina added the bug label Aug 18, 2020
@mattfarina
Copy link
Contributor

Good catch, thanks.

mattfarina added a commit to mattfarina/helm-www that referenced this issue Aug 18, 2020
@mattfarina
Removing aliases from ja translation
dbf959d 
Translations should not have aliases. When that happens they
override the english language aliases.

Closes helm#773

Signed-off-by: Matt Farina <matt@mattfarina.com>
This was referenced Aug 18, 2020
Merged
Open
flynnduism pushed a commit to flynnduism/helm-www that referenced this issue Aug 24, 2020
@mattfarina @flynnduism
Removing aliases from ja translation
7270a15 
Translations should not have aliases. When that happens they
override the english language aliases.

Closes helm#773

Signed-off-by: Matt Farina <matt@mattfarina.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing aliases from ja translation mattfarina/helm-www
2 participants
@mattfarina @lindhe