Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

and and or functions can take many arguments #1232

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

haines
Copy link
Contributor

@haines haines commented Nov 3, 2021

The docs currently state that the and and or functions take two arguments, but this isn't true - they are variadic.

I think a similar change is needed in Chinese and Korean, but unfortunately I don't speak either of those languages!

Signed-off-by: Andrew Haines <andrew@haines.org.nz>
@bridgetkromhout
Copy link
Member

Thanks, @haines! We'll have a maintainer of the helm/helm codebase validate this update and then hopefully get it in. Appreciated.

Copy link
Member

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bridgetkromhout
Copy link
Member

I think a similar change is needed in Chinese and Korean

@haines The contributors for those languages pull in changes from the English docs from time to time, so this is a fine place to update it. Thanks!

@bridgetkromhout bridgetkromhout merged commit e9410e8 into helm:main Dec 2, 2021
@haines haines deleted the and-or branch December 2, 2021 22:07
@haines
Copy link
Contributor Author

haines commented Dec 2, 2021

Fantastic, thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants