Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/docker/docker from 25.0.5+incompatible to 25.0.6+incompatible #13226

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 1, 2024

Bumps github.com/docker/docker from 25.0.5+incompatible to 25.0.6+incompatible.

Release notes

Sourced from github.com/docker/docker's releases.

v25.0.6

25.0.6

For a full list of pull requests and changes in this release, refer to the relevant GitHub milestones:

Security

This release contains a fix for CVE-2024-41110 / GHSA-v23v-6jw2-98fq that impacted setups using authorization plugins (AuthZ) for access control.

Bug fixes and enhancements

  • [25.0] remove erroneous platform from image config OCI descriptor in docker save output. moby/moby#47695
  • [25.0 backport] Fix a nil dereference when getting image history for images having layers without the Created value set. moby/moby#47759
  • [25.0 backport] apparmor: Allow confined runc to kill containers. moby/moby#47830
  • [25.0 backport] Fix an issue where rapidly promoting a Swarm node after another node was demoted could cause the promoted node to fail its promotion. moby/moby#47869
  • [25.0 backport] don't depend on containerd platform.Parse to return a typed error. moby/moby#47890
  • [25.0 backport] builder/mobyexporter: Add missing nil check moby/moby#47987

Packaging updates

Full Changelog: moby/moby@v25.0.5...v25.0.6

Commits
  • b08a51f Merge pull request #48231 from austinvazquez/backport-vendor-otel-v0.46.1-to-...
  • d151b0f vendor: OTEL v0.46.1 / v1.21.0
  • c6ba9a5 Merge pull request #48225 from austinvazquez/backport-workflow-artifact-reten...
  • 4673a3c Merge pull request #48227 from austinvazquez/backport-backport-branch-check-t...
  • 30f8908 github/ci: Check if backport is opened against the expected branch
  • 7454d6a ci: update workflow artifacts retention
  • 65cc597 Merge commit from fork
  • b722836 Merge pull request #48199 from austinvazquez/update-containerd-binary-to-1.7.20
  • e8ecb9c update containerd binary to v1.7.20
  • e6cae1f update containerd binary to v1.7.19
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 25.0.5+incompatible to 25.0.6+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v25.0.5...v25.0.6)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 1, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2024
@AivarasPuskorius AivarasPuskorius mentioned this pull request Aug 2, 2024
@mkjpryor
Copy link

mkjpryor commented Aug 5, 2024

Hopefully this can merge and be released quickly, because the existence of a critical CVE in Helm is currently breaking our builds.

@mkjpryor
Copy link

mkjpryor commented Aug 6, 2024

@mattfarina

Don't mean to nag, but any chance this can get merged and into a patch release ASAP? The CVE has been open for nearly two weeks and is blocking a lot of people.

@scottrigby scottrigby self-assigned this Aug 6, 2024
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a false positive. Helm does not use the affected functionality in docker engine. This is an indirect dependency of ORAS v1, which Helm registry package only uses to pull images. However merging this to help reduce noise from others importing Helm.

This can be evidenced with govulncheck:

$ git switch --detach v3.15.3
$ govulncheck ./...
Scanning your code and 961 packages across 149 dependent modules for known vulnerabilities...
=== Symbol Results ===
No vulnerabilities found.
Your code is affected by 0 vulnerabilities.
This scan also found 0 vulnerabilities in packages you import and 1
vulnerability in modules you require, but your code doesn't appear to call these
vulnerabilities.
Use '-show verbose' for more details.

It would be helpful and appreciated to work with your vendor(s) to reduce these false positives. They cause a lot of noise (for everyone).

For this specific version bump. Since this not an actual issue, it will go into the next patch release (v3.15.4), scheduled for next Wednesday (see the "Release Calendar" on https://helm.sh/).

@scottrigby scottrigby merged commit 5a114ac into main Aug 6, 2024
8 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/docker/docker-25.0.6incompatible branch August 6, 2024 19:49
@scottrigby scottrigby added this to the 3.15.4 milestone Aug 6, 2024
@mattfarina mattfarina added the picked Indicates that a PR has been cherry-picked into the next release candidate. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code picked Indicates that a PR has been cherry-picked into the next release candidate. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants