Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to download kind/kubectl on macOS GHA runners #89

Closed
wants to merge 1 commit into from

Conversation

nicks
Copy link

@nicks nicks commented Jul 11, 2023

Important note - This doesn't setup Docker on MacOS. To setup Docker, you either need to use the Docker Desktop GHA (https://github.com/docker/desktop-action), or you need to connect your MacOS runner to a remote Docker Daemon.

@nicks
Copy link
Author

nicks commented Jul 11, 2023

(I wanted to use this package to leverage kind for integration tests on Docker Desktop itself)

kind.sh Outdated Show resolved Hide resolved
@nicks nicks requested a review from musse August 17, 2023 17:53
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

can you rebase and maybe add a test case that runs on macos?

thanks for this PR and very sorry for the delay

@nicks
Copy link
Author

nicks commented Feb 14, 2024

added a macos test rule

@nicks nicks requested a review from cpanato February 14, 2024 19:52
@cpanato
Copy link
Member

cpanato commented Feb 19, 2024

@nicks the new mac testing is failing

Comment on lines +71 to +76

test-with-macos-install-only:
runs-on: macos-latest
steps:
- name: Checkout
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test-with-macos-install-only:
runs-on: macos-latest
steps:
- name: Checkout
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
test-with-macos-install-only:
runs-on: macos-latest
steps:
- name: Checkout
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Setup docker
run: |
brew install docker
colima start

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this fix on my fork, it works: musse#1

Check this thread for details: actions/runner-images#17 (comment)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this is right; you shouldn't need colima running if the action is in install_only mode

Important note - This doesn't setup Docker on MacOS.
To setup Docker, you either need to use the Docker Desktop GHA (https://github.com/docker/desktop-action),
or you need to connect your MacOS runner to a remote Docker Daemon.

Signed-off-by: Nick Santos <nick.santos@docker.com>
@nicks
Copy link
Author

nicks commented Feb 20, 2024

the test failure might be revealing an existing bug in the cleanup script?

currently it always runs kind delete, even if the action has install_only set to true.

arguably, if install_only is set to true, then it's not responsible for creating a cluster, so also shouldn't be responsible for cleaning one up?

for now, i set ignore_failed_clean on the new test, which is arguably the "safest" change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants