This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 220
Chart file metadata doesn't change for same version numbers #555
Comments
prydonius
pushed a commit
to prydonius/monocular
that referenced
this issue
Nov 1, 2018
Previously, chart-repo skipped indexing any chart versions previous indexed based on the repo, name and version. However, if a user modifies a chart version without bumping a new version, the changes are not taken into account. This changes chart-repo to skip based on the above AND the digest of the chart package so that packages with a new digest are correctly updated. See also vmware-tanzu/kubeapps#659 fixes helm#555
prydonius
pushed a commit
to prydonius/monocular
that referenced
this issue
Nov 1, 2018
Previously, chart-repo skipped indexing any chart versions previous indexed based on the repo, name and version. However, if a user modifies a chart version without bumping a new version, the changes are not taken into account. This changes chart-repo to skip based on the above AND the digest of the chart package so that packages with a new digest are correctly updated. See also vmware-tanzu/kubeapps#659 fixes helm#555 Signed-off-by: Adnan Abdulhussein <adnan@bitnami.com>
prydonius
added a commit
that referenced
this issue
Nov 2, 2018
* enable ability to index new chart data for the same chart version Previously, chart-repo skipped indexing any chart versions previous indexed based on the repo, name and version. However, if a user modifies a chart version without bumping a new version, the changes are not taken into account. This changes chart-repo to skip based on the above AND the digest of the chart package so that packages with a new digest are correctly updated. See also vmware-tanzu/kubeapps#659 fixes #555 Signed-off-by: Adnan Abdulhussein <adnan@bitnami.com> * update kubeapps/common dep to pull in fix for tests Signed-off-by: Adnan Abdulhussein <adnan@bitnami.com> * add comments Signed-off-by: Adnan Abdulhussein <adnan@bitnami.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As reported in vmware-tanzu/kubeapps#659, new chart packages for a specific chart version pushed after chart-repo has already synced the version are not updated. chart-repo assumes it has already been synced and skips it, but currently this is done based on the chart repo, name and version, and not on the digest.
vmware-tanzu/kubeapps#659 proposes that we store the digest along with the chart files, which we can use to compare and decide whether or not to skip indexing.
The text was updated successfully, but these errors were encountered: