Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

tests(data): added test coverage to data package #16

Merged
merged 1 commit into from
Sep 29, 2016
Merged

tests(data): added test coverage to data package #16

merged 1 commit into from
Sep 29, 2016

Conversation

jackfrancis
Copy link
Contributor

$ go test -cover
PASS
coverage: 91.7% of statements
ok      github.com/helm/monocular/src/api/data  0.081s

We can't get to 100% until we implement interfaces instead of static mock functions. Stay tuned for that!

charts, err := helpers.ParseYAMLRepo(y)
if err != nil {
log.Fatalf("couldn't parse mock repo!")
log.Printf("couldn't parse mock repo %s!\n", repo)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol... Fatalf is evil.

@jackfrancis jackfrancis merged commit 23c4627 into helm:master Sep 29, 2016
@jackfrancis jackfrancis deleted the tests-data branch September 30, 2016 22:34
remstos added a commit to remstos/monocular that referenced this pull request Jul 3, 2017
prydonius pushed a commit that referenced this pull request Jul 19, 2017
* Reorganize deployment list

* Add ChartIcon to deployment

* Add filters + Search input

* Fix link + default namespace

* Deployment details layout update

* ChartIcon in release extended

* Add chart icon color theming

* Fix list alignments

* Prevent chart icon not showing up

* Update Swagger spec for chartIcon

* Deployment subtitle style clean

* Cleanup headerbar

* Add deployment to small menu

* Improve small navbar style/animation

* Colorful card style chart-item

* Reorganize charts list

* Chart Details profile style

* Charts list overall ui fixes

* Allow search in repo

* Use custom module for color picking

* Fix too long chart/deployment name #16

* Add search icon on charts/deployments search field

* Fix UI Tests

* Fix chart list alignment + no charts result

* Improve search bars

* Remove chart-search route

* Fix empty charts list state

* Clean sass selector alignment

* Css variable cleanup + Fix most review comments

* Use colors from theme.scss everywhere

* Optimize search svg

* Refactor List Item

* Refactor list filters for chart & deployments

* Relayout header-bar + maxwidth layout on main page

* Fix test and compile script

* Back to previous chart layout + large max layout width

* Add xlarge breakpoint

* Fix url-join and marked imports

* Update swagger spec
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants