Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

fix CORS for deployments #302

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Conversation

prydonius
Copy link
Member

@prydonius prydonius commented Jun 29, 2017

This sets the correct allowed headers by default so that deployments can be created when Monocular is deployed with differing hostnames

fixes #291

@prydonius
Copy link
Member Author

The test passed the second time: https://travis-ci.org/helm/monocular/builds/248339637

@Angelmmiguel
Copy link
Member

Before merge it, please review the tests

@prydonius prydonius merged commit 8364dab into helm:master Jun 29, 2017
@prydonius prydonius deleted the 291-fix-cors-deployments branch June 29, 2017 14:13
@codecov-io
Copy link

Codecov Report

Merging #302 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   90.42%   90.42%           
=======================================
  Files          18       18           
  Lines         971      971           
=======================================
  Hits          878      878           
  Misses         62       62           
  Partials       31       31
Impacted Files Coverage Δ
src/api/config/cors/cors.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 573ad36...4f6c113. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployments not working with frontend and api on different domains
3 participants