-
Notifications
You must be signed in to change notification settings - Fork 220
Update chart resources apiVersion #644
Update chart resources apiVersion #644
Conversation
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
@mattfarina @absoludity Are either of ye able to review/approve/merge? Or who is best to ask? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattfarina @absoludity Are either of ye able to review/approve/merge?
Or who is best to ask?
I don't have perms to land things in the helm org., but changes look good. Thanks!
The CI only bumps the chart version if we have tagged a release for new code changes, but chart changes that aren't tied to a code release should manually bump the version. I think this is a non-breaking change, so we should bump the patch version of the chart here. |
@prydonius Sure. I wasn't certain if updating mongodb dep version was a breaking change. Thanks for the review. I've bumped the patch version of the chart. |
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
cbcde38
to
2285b9e
Compare
Rebumped chart version 2 patches - under the assumption that #647 will be merged first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @Dean-Coakley!
Fixes: #636
Issue:
This is a required change to make the chart installable on Kubernetes 1.16.
Proposed changes:
Update all
Deployment
resources of the chart toapps/v1
as required by Kubernetes 1.16Update
mongodb
chart dependency. From4.6.2
->7.2.10
.mongodb:4.6.2
also used the deprecated"extensions/v1beta1"
apiVersion.Add
spec.selector
as required by the new apiVersion.Note:
I did not increment the
version
of the chart. It looks like this is done via CI?