Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Update chart resources apiVersion #644

Merged
merged 5 commits into from
Oct 7, 2019

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Sep 28, 2019

Fixes: #636

Issue:

This is a required change to make the chart installable on Kubernetes 1.16.

Proposed changes:

  • Update all Deployment resources of the chart to apps/v1 as required by Kubernetes 1.16

  • Update mongodb chart dependency. From 4.6.2 -> 7.2.10.

    • This was required because mongodb:4.6.2 also used the deprecated "extensions/v1beta1" apiVersion.
  • Add spec.selector as required by the new apiVersion.

    Error: release monocular-dev failed: Deployment.apps "monocular-dev-monocular-ui" is invalid: [spec.selector: Required value, spec.template.metadata.labels: Invalid value: map[string]string{"app":"monocular-dev-monocular-ui"}: selector does not match template labels]

Note:

I did not increment the version of the chart. It looks like this is done via CI?

Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
@Dean-Coakley
Copy link
Contributor Author

Dean-Coakley commented Oct 1, 2019

@mattfarina @absoludity Are either of ye able to review/approve/merge?

Or who is best to ask?

Copy link

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattfarina @absoludity Are either of ye able to review/approve/merge?

Or who is best to ask?

I don't have perms to land things in the helm org., but changes look good. Thanks!

@prydonius
Copy link
Member

The CI only bumps the chart version if we have tagged a release for new code changes, but chart changes that aren't tied to a code release should manually bump the version. I think this is a non-breaking change, so we should bump the patch version of the chart here.

@Dean-Coakley
Copy link
Contributor Author

@prydonius Sure. I wasn't certain if updating mongodb dep version was a breaking change.

Thanks for the review. I've bumped the patch version of the chart.

Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
@Dean-Coakley
Copy link
Contributor Author

Rebumped chart version 2 patches - under the assumption that #647 will be merged first

Copy link
Member

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Dean-Coakley!

@prydonius prydonius merged commit 26dc59e into helm:master Oct 7, 2019
@Dean-Coakley Dean-Coakley deleted the update-chart-resources-ver branch October 7, 2019 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update chart to stable resources
4 participants