Improve tests around various policies

This (1) only does one `any` cast (2) tries to make the tests a little more realistic; things someone might do by accident.
helmetjs · Jun 25, 2022 · 9b88c00 · 9b88c00
1 parent 94a7468
commit 9b88c00
Show file tree

Hide file tree

Showing 6 changed files with 41 additions and 34 deletions.
diff --git a/test/cross-origin-embedder-policy.test.ts b/test/cross-origin-embedder-policy.test.ts
@@ -29,16 +29,16 @@ describe("Cross-Origin-Embedder-Policy middleware", () => {
   it("throws when setting the policy to an invalid value", () => {
     const invalidValues = [
       "",
-      "NONE",
-      "by-ftp-filename",
-      123 as any,
-      null as any,
-      new String("none") as any,
+      "foo",
+      "CREDENTIALLESS",
+      123,
+      null,
+      new String("credentialless"),
     ];
     for (const policy of invalidValues) {
-      expect(() => crossOriginEmbedderPolicy({ policy })).toThrow(
-        /^Cross-Origin-Embedder-Policy does not support /
-      );
+      expect(() =>
+        crossOriginEmbedderPolicy({ policy: policy as any })
+      ).toThrow(/^Cross-Origin-Embedder-Policy does not support /);
     }
   });
 });
diff --git a/test/cross-origin-opener-policy.test.ts b/test/cross-origin-opener-policy.test.ts
@@ -28,14 +28,14 @@ describe("Cross-Origin-Opener-Policy middleware", () => {
   it("throws when setting the policy to an invalid value", () => {
     const invalidValues = [
       "",
-      "NONE",
-      "by-ftp-filename",
-      123 as any,
-      null as any,
-      new String("none") as any,
+      "foo",
+      "SAME-ORIGIN",
+      123,
+      null,
+      new String("same-origin"),
     ];
     for (const policy of invalidValues) {
-      expect(() => crossOriginOpenerPolicy({ policy })).toThrow(
+      expect(() => crossOriginOpenerPolicy({ policy: policy as any })).toThrow(
         /^Cross-Origin-Opener-Policy does not support /
       );
     }

diff --git a/test/cross-origin-resource-policy.test.ts b/test/cross-origin-resource-policy.test.ts
@@ -29,16 +29,16 @@ describe("Cross-Origin-Resource-Policy middleware", () => {
   it("throws when setting the policy to an invalid value", () => {
     const invalidValues = [
       "",
-      "NONE",
-      "by-ftp-filename",
-      123 as any,
-      null as any,
-      new String("none") as any,
+      "foo",
+      "CROSS-ORIGIN",
+      123,
+      null,
+      new String("none"),
     ];
     for (const policy of invalidValues) {
-      expect(() => crossOriginResourcePolicy({ policy })).toThrow(
-        /^Cross-Origin-Resource-Policy does not support /
-      );
+      expect(() =>
+        crossOriginResourcePolicy({ policy: policy as any })
+      ).toThrow(/^Cross-Origin-Resource-Policy does not support /);
     }
   });
 });
diff --git a/test/referrer-policy.test.ts b/test/referrer-policy.test.ts
@@ -48,12 +48,10 @@ describe("Referrer-Policy middleware", () => {
   });
 
   it("fails with a bad policy", () => {
-    expect(referrerPolicy.bind(null, { policy: "garbage" })).toThrow();
-    expect(referrerPolicy.bind(null, { policy: "sameorigin" })).toThrow();
-    expect(referrerPolicy.bind(null, { policy: 123 as any })).toThrow();
-    expect(referrerPolicy.bind(null, { policy: false as any })).toThrow();
-    expect(referrerPolicy.bind(null, { policy: null as any })).toThrow();
-    expect(referrerPolicy.bind(null, { policy: {} as any })).toThrow();
+    const invalidValues = ["foo", "sameorigin", "ORIGIN", 123, false, null, {}];
+    for (const policy of invalidValues) {
+      expect(referrerPolicy.bind(null, { policy: policy as any })).toThrow();
+    }
   });
 
   it("fails with an empty array", () => {

diff --git a/test/x-frame-options.test.ts b/test/x-frame-options.test.ts
@@ -54,8 +54,15 @@ describe("X-Frame-Options middleware", () => {
       );
     }
 
-    for (const action of ["garbage", "", 123 as any, null as any]) {
-      expect(() => xFrameOptions({ action })).toThrow(
+    for (const action of [
+      "",
+      "foo",
+      " deny",
+      123,
+      null,
+      new String("SAMEORIGIN"),
+    ]) {
+      expect(() => xFrameOptions({ action: action as any })).toThrow(
         /^X-Frame-Options received an invalid action /
       );
     }

diff --git a/test/x-permitted-cross-domain-policies.test.ts b/test/x-permitted-cross-domain-policies.test.ts
@@ -33,13 +33,15 @@ describe("X-Permitted-Cross-Domain-Policies middleware", () => {
       "",
       "NONE",
       "by-ftp-filename",
-      123 as any,
-      null as any,
-      new String("none") as any,
+      123,
+      null,
+      new String("none"),
     ];
     for (const permittedPolicies of invalidValues) {
       expect(() =>
-        xPermittedCrossDomainPolicies({ permittedPolicies })
+        xPermittedCrossDomainPolicies({
+          permittedPolicies: permittedPolicies as any,
+        })
       ).toThrow(/^X-Permitted-Cross-Domain-Policies does not support /);
     }
   });