Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard to understand what are the defaults values #376

Closed
AlonMiz opened this issue Jul 26, 2022 · 2 comments
Closed

Hard to understand what are the defaults values #376

AlonMiz opened this issue Jul 26, 2022 · 2 comments

Comments

@AlonMiz
Copy link

AlonMiz commented Jul 26, 2022 •
edited
Loading

when using helmet, im struggling to understand the default values.
especially with the version 5 changes in default values...
what is the result in using:
app.use(helmet())
would be great to see that object in the docs
Thanks
EvanHahn added a commit that referenced this issue Jul 27, 2022
@EvanHahn
Update documentation
b99131e 
Inspired by [this issue][0], this clarifies what the default values are.

[0]: #376
@EvanHahn
Copy link
Member

You're right. This is a little confusing.

I've updated the readme in b99131e to make this clearer.

@AlonMiz
Copy link
Author

AlonMiz commented Aug 9, 2022

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EvanHahn @AlonMiz