Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PyTorch 2.6.0 / Add zarr as optional dependency #1775

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 30, 2025

Run tests on latest PyTorch release
Issue/s resolved: #1774
TODO:

@mrfh92 mrfh92 marked this pull request as ready for review January 31, 2025 09:28
@mrfh92
Copy link
Collaborator

mrfh92 commented Jan 31, 2025

Steps done

  • (added optional zarr support to setup.py as it makes sense to to this if we need to change things on codebase anyway)
  • created branch pytorch261 on codebase (based on previous branch pytorch251)
    • in this new branch, I have adapted the installation instructions for PyTorch accordingly (both for AMD and Nvidia);
    • changing the base images was not necessary as CUDA and ROCm versions in these images were fine
    • (in addition, I have added the optional zarr dependency to the pip install command for installing Heat)
  • changed the version of pytorchxyz in the heat/support branch to 261 to let the CI for this PR run with the yaml file from pytorch261-branch already
  • after everything mentioned above was done in the right way (i.e. whithout demanding option cu126 from the wheels channel cu124 etc. ) the run succeeded ---> we are ready for PyTorch 2.6.0 on main
  • approved in order to let CI matrix run
  • since everything was fine, I set pytorch261 in the yaml files in the branches heat/base (CI runs on main) and heat/pr (CI runs for PRs) on codebase
  • ... and merged this PR

@mrfh92 mrfh92 changed the title Support PyTorch 2.6.0 Support PyTorch 2.6.0 / Add zarr as optional dependency Jan 31, 2025
@mrfh92 mrfh92 mentioned this pull request Jan 31, 2025
6 tasks
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (d66e404) to head (eda2c72).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1775   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files          84       84           
  Lines       12447    12447           
=======================================
  Hits        11484    11484           
  Misses        963      963           
Flag Coverage Δ
unit 92.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrfh92 mrfh92 mentioned this pull request Jan 31, 2025
@mrfh92 mrfh92 merged commit 77af671 into main Jan 31, 2025
60 checks passed
@mrfh92 mrfh92 mentioned this pull request Jan 31, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new PyTorch release
2 participants