Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runs CI for all crates in workspace #140

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Runs CI for all crates in workspace #140

merged 2 commits into from
Oct 23, 2023

Conversation

xfbs
Copy link
Contributor

@xfbs xfbs commented Oct 20, 2023 •
edited
Loading

Currently, only the buffrs CLI is the recipient of CI scrutiny. This PR makes it so that all crates are checked.

The way this is done is by adding --all or --workspace flags to the tools. Examples:

cargo test --all
cargo clippy --workspace
cargo fmt --all --check

This addresses #139.
One issue that also cropped up and is fixed by this is #141.

@xfbs xfbs added complexity::low Issues or ideas with a low implementation cost priority::low Please dont work on this if you can contribute something with a higher priority type::fix labels Oct 20, 2023
@xfbs xfbs self-assigned this Oct 20, 2023
@xfbs xfbs force-pushed the pe/ci-all branch 5 times, most recently from f7515ec to f5f6a62 Compare October 20, 2023 11:40
mara-schulke
mara-schulke reviewed Oct 20, 2023
View reviewed changes
src/credentials.rs Outdated Show resolved Hide resolved
@mara-schulke
Copy link
Contributor

Except for the changed semantics, lgtm

@xfbs
Copy link
Contributor Author

xfbs commented Oct 23, 2023

I've just rebased this due to changes in main. Had to fix one issue related to PackageStore to make it build.

@xfbs xfbs merged commit 069eca3 into main Oct 23, 2023
@xfbs xfbs deleted the pe/ci-all branch October 23, 2023 13:44
@mara-schulke mara-schulke mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mara-schulke mara-schulke mara-schulke approved these changes

Assignees

@xfbs xfbs

Labels
complexity::low Issues or ideas with a low implementation cost priority::low Please dont work on this if you can contribute something with a higher priority type::fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xfbs @mara-schulke