-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .buffrs/config.toml and allow dots in package names #251
Conversation
Add .buffrs/config.toml registries and hierarchical packages
Can we split the features here into multiple MRs? Eg. I'm happy to accept the deps only flag fairly instantly whereas I have concerns about the implications of the config file -> This needs to be thoroughly designed for not hurting dependency resolution (ie. what happens when you declare different registries than your consumers? How do you deal with diverging default registries?) |
I disagree with the fact that this should be configurable by the user! I'm happy to change the default behavior of buffrs to hierarchical packages if there is a really well reasoned and thoughtful solution proposed! Ie. I see three different features / MRs here:
|
@mara-schulke : yes, you are right. And on top of that, I think that the correct solution isn't about interpreting package names as hierarchical, but instead to allow the published packages to have their protos in subfolders. That way, one can define e.g. a package named
In fact, such a package could contain proto files anywhere below proto. However, when doing a
Note that I intentionally:
|
The config file is hierarchical -- so one can simply override the config file by defining another one a level below. |
Fair enough, and I'll try to submit these in 3 separate PRs. The deps-only + import system actually go together. The final purpose being to make the result compatible with |
Based on upstream version 0.8.1 but with following additions:
buffrs install --only-dependencies
to only install dependent packages into the vendor folder. This allows thebuf
linter to be run on the main proto files of a package without triggering errors due to duplicate definitions..
in package names for hierarchical organization of protos in the vendor folderFurthermore, this release allows use of
.
in the package name of the Proto.tomlExample: