Feature/concept type backend search #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concept_types dict added to results with types and number of results. types parameter added to API query dict, restricting search results to set of types.
|
@mbacon-renci Have you done the UI changes for this as well, or will that still need to get done? Also, I don't think the |
|
@frostyfan109 I have done no UI changes at this point. That will still need to get done. I was reading this ticket as focused on back-end work and just did that. The .env change wasn't supposed to go in there, I must have done a git commit -a when I didn't mean to. I will clear that out and update. |
YaphetKG
reviewed
Jul 31, 2023
src/dug/core/async_search.py
Outdated
| """ | ||
| query_object = {'query': self._build_concepts_query(query, **kwargs)} | ||
| total_items = await self.es.count( | ||
| body=json.dumps(query_object), |
There was a problem hiding this comment.
this probably should be a dict instead of json string when sending queries to es. @braswent had some issues when using later versions of elastic search
|
Hi @YaphetKG and @frostyfan109 can you please review the updated changes? |
YaphetKG
approved these changes
Aug 1, 2023
frostyfan109
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements server-side concept type filtering. All queries now add a 'concept_types' object entry to the reply JSON object, itself a JSON object that provides concept types that match the query and counts of how many documents match. The request object for the concept search also now accepts an optional 'types' parameter, which can be a list of types. Responses will be limited to concepts that match one of the entries in the list.
Fulfills DUG-58