Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

329 annotator modules #330

Merged
merged 6 commits into from
Jan 3, 2024
Merged

329 annotator modules #330

merged 6 commits into from
Jan 3, 2024

Conversation

braswent
Copy link
Collaborator

Changed the DugAnnotator class into a plugin called Annotator.

Similar to the implementation of Parsers you must pass in the type of annotator you want and it will implement the annotator for your Dug service

  • Tests are updated with an integration test mocking the monarch annotator functionality
  • BUG FIX on cli.py search where passing the index was crashing the application
  • Default synonym_finder and normalizer for now, that can change into new plugins if there are new components to implement in the future

@braswent braswent self-assigned this Oct 31, 2023
@braswent braswent linked an issue Oct 31, 2023 that may be closed by this pull request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just yank this file out it seems like its just comments

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, a git rm probably more suitable there than commenting out the whole file.

@YaphetKG YaphetKG merged commit 2852f22 into develop Jan 3, 2024
@YaphetKG YaphetKG deleted the 329-annotator-modules branch January 3, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for alternate annotator classes
3 participants