Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHTabBarView by default overlaps inner view controllers #13

Closed
gerchicov-bp opened this issue Dec 13, 2018 · 2 comments
Closed

HHTabBarView by default overlaps inner view controllers #13

gerchicov-bp opened this issue Dec 13, 2018 · 2 comments
Assignees

Comments

@gerchicov-bp
Copy link

For example create a view/view controller with table with a lot of items and try to scroll it to the bottom - the last cell is hidden by tab bar

@hemangshah
Copy link
Owner

Hi @gerchicov-bp I believe, this isn't an issue of HHTabBarView. It's because of your table's bottom constraint.

@hemangshah hemangshah reopened this Dec 15, 2018
hemangshah added a commit that referenced this issue Dec 15, 2018
Addex table in Location tabs to see that HHTabBarView is not overlapped for the given constraints (Referece: #13)
@hemangshah
Copy link
Owner

hemangshah commented Dec 15, 2018

Hi @gerchicov-bp , I have updated the codebase for swift 4.2 and added a table in Locations tab (in Example) to show case that how to fix this overlap issue. FYR, I am also adding two screenshots here to let you know how to fix it by your self. If you still need help just comment here and I would be happy to help.

How to activate Safe Area Layout Guide for a view controller (Note: With latest Xcode and new project, this is by default).

1

Setting/Updating Constraints for the TableView as per the screenshot:

2

Why 49 for Align bottom to Safe area? because HHTabBarView's height is 49.

@hemangshah hemangshah self-assigned this Dec 15, 2018
@hemangshah hemangshah pinned this issue Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants