Keep the shebang intact #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bang-carrying input files.
…g, IFF the file has any. This fixes silesky/prepend-header#5
- clean up *before* rather than *after*: we want to *start* clean, if we leave a bit of stuff for post-test scrutiny that's okay. Anyway, had a couple of nasty surprises by crashing tests and the *after* code not working, anyway.
|
BTW: comes including extra tests and adjusted README. |
Richienb
reviewed
Aug 11, 2020
| } | ||
|
|
||
| function extractHashBang(text) { | ||
| const m = /^(#![^\r\n]+)/.exec(text.toString()); |
There was a problem hiding this comment.
We should use more descriptive variable names.
Richienb
reviewed
Aug 11, 2020
Richienb
reviewed
Aug 11, 2020
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "name": "prepend-file", | |||
| "version": "1.3.1", | |||
| "name": "prepend-to-js-file", | |||
There was a problem hiding this comment.
Don't do unrelated changes.
There was a problem hiding this comment.
From the PR:
Hence you might want to cherry-pick instead of executing a straight merge of this work.
😉
Didn't have enough time to do a cleaned-up PR, alas.
Richienb
reviewed
Aug 11, 2020
| test.after.always(async () => { | ||
| await fsP.unlink(temporaryFile); | ||
| await fsP.unlink(syncTemporaryFile); | ||
| function ignoreFailure(f) { |
There was a problem hiding this comment.
We can probably just use https://www.npmjs.com/package/del.
Richienb
reviewed
Aug 11, 2020
| await prependFile(shebangTemporaryFile, Buffer.from('Yes ')); | ||
| t.is(await fsP.readFile(shebangTemporaryFile, 'utf8'), '#! /bin/shebang\n\nYes Hello World'); | ||
|
|
||
| // `prependFile()` does not recognize a BOM in the part to be appended, so we test BOM-prefixed files by using afresh one here: |
There was a problem hiding this comment.
This comment won't be necessary.
Richienb
reviewed
Aug 11, 2020
| @@ -1,6 +1,8 @@ | |||
| # prepend-file [![Build Status][travis-image]][travis-url] [![Code Coverage][coveralls-image]][coveralls-url] | |||
|
|
|||
| > Prepend data to a file, creating it if it doesn't exist. | |||
| > | |||
| > When the file (*to be prepended to*) has [a 'hash bang' a.k.a. *shebang* command](https://en.wikipedia.org/wiki/Shebang_(Unix)) at the first line, this will be kept intact. | |||
There was a problem hiding this comment.
I think this should be an option.
Richienb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as for the UTF8 BOM recognition, only this time for
#!xyz...shebangs.This was needed to fix silesky/prepend-header#5 -- I don't know if you like to incorporate this new behaviour in your module, so I forked the repo and created another npm package:
prepend-to-js-fileby renaming this one.Hence you might want to cherry-pick instead of executing a straight merge of this work.
Thanks!