Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to store cache on alpine linux due to missing bash #215

Closed
hendrikmuhs opened this issue Jul 11, 2024 · 0 comments · Fixed by #223
Closed

Fails to store cache on alpine linux due to missing bash #215

hendrikmuhs opened this issue Jul 11, 2024 · 0 comments · Fixed by #223
Labels
good first issue Good for newcomers

Comments

@hendrikmuhs
Copy link
Owner

hendrikmuhs commented Jul 11, 2024 •
edited
Loading

See #214 (comment)

we shouldn't use bash, but sh works, there was already a PR: #145, but there is one more place. The method names should also be changed.

Marking as "good first issue", seems an easy change, maybe someone wants to pick this up?
@hendrikmuhs hendrikmuhs added the good first issue Good for newcomers label Jul 11, 2024
@hendrikmuhs hendrikmuhs mentioned this issue Jul 11, 2024
Merged
hansfn added a commit to hansfn/ccache-action that referenced this issue Aug 9, 2024
@hansfn
Change Bash to Shell everywhere
545c2c1 
Updates function names to match the earlier change from "bash" to "sh".
Removes last instance of "bash" execution.

Resolves hendrikmuhs#215
@hansfn hansfn mentioned this issue Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Bash to Shell everywhere hansfn/ccache-action
1 participant
@hendrikmuhs