Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sccache to PATH after installation #204

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

kendalharland
Copy link
Contributor

This action installs sccache under $USERPROFILE/.cargo/bin. GitHub runner images already have $USERPROFILE/.cargo/bin in the PATH, but self-hosted runners may not. This PR makes this action update the user's PATH to include the installation directory. This allows self-hosted runners to find sccache and prevents breakages in the unlikely event that a different installation directory is chosen in the future.

Note: I recently closed a duplicate PR with the intention of merging from a different fork but it is easier to merge from kendalharland:main

@kendalharland
Copy link
Contributor Author

Hi @hendrikmuhs, friendly reminder to PTAL when you can.

@hendrikmuhs
Copy link
Owner

Thanks @kendalharland !

I can not really judge as I am not using this functionality. I wonder if changing the PATH in this action helps finding the binary in following actions in a github workflow. Normally that's not the case. But I guess you have tested it and can confirm?

@compnerd
Copy link
Contributor

@hendrikmuhs yes, that is the case - it helps find the executable. This would only apply for the job in which the extension is used as each job itself resets the environment.

@hendrikmuhs hendrikmuhs merged commit 2e0e89e into hendrikmuhs:main Jun 14, 2024
41 checks passed
@kendalharland
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants