feat(config): Add config struct #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Bryysen @FObersteiner Please have a look. |
…unctionality * - Store all computed metrics in BenchmarkResult and move report/pretty-print functionality into BenchmarkResult - Update examples - Add total-time metric and display it when pretty-printing * Refactor and improve/tweak printing logic and doc-comments - Split BenchmarkResult.prettyPrint into individual functions with respect to each metric to be pretty-printed - Propagate choice of writer for pretty-print functions within BenchmarkResult - Add a buffered std-out writer as a field of BenchmarkResults. We use this for all formatted printing-operations within BenchmarkResults. - Make use of BenchmarkResults.getColor to color-code the total-time metric in BenchmarkResults.prettyPrint - Add various doc-comments * Add more/improve doc comments * - Move individual pretty-print functions to util/format - Rename BenchmarkResult.percs to BenchmarkResult.percentiles
After 1389ebf we forget to print a newline in the for-loop within BenchmarkResults.prettyPrint, causing messed-up formatting. We also forgot to call BenchmarkResults.getColor when determining the color for total-time. Both of these are now fixed. Also moved prettyPrintHeader to util/format.zig for consistency.
…unctionality * - Store all computed metrics in BenchmarkResult and move report/pretty-print functionality into BenchmarkResult - Update examples - Add total-time metric and display it when pretty-printing * Refactor and improve/tweak printing logic and doc-comments - Split BenchmarkResult.prettyPrint into individual functions with respect to each metric to be pretty-printed - Propagate choice of writer for pretty-print functions within BenchmarkResult - Add a buffered std-out writer as a field of BenchmarkResults. We use this for all formatted printing-operations within BenchmarkResults. - Make use of BenchmarkResults.getColor to color-code the total-time metric in BenchmarkResults.prettyPrint - Add various doc-comments * Add more/improve doc comments * - Move individual pretty-print functions to util/format - Rename BenchmarkResult.percs to BenchmarkResult.percentiles
* chore(ci): remove zig master build * chore(ci): rename build examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new configuration option in
zbenchthat allows users to specifythe number of iterations for benchmarks. This update modifies the
runfunctionto prioritize user-defined iteration count from
Config.iterationsover theautomatic calculation based on minimum duration. This enhancement provides
greater flexibility in benchmarking by accommodating specific iteration requirements.