Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stat): elapsed time is negative #213

Merged
merged 2 commits into from
Dec 24, 2024
Merged

fix(stat): elapsed time is negative #213

merged 2 commits into from
Dec 24, 2024

Conversation

hengyoush
Copy link
Owner

@hengyoush hengyoush commented Dec 24, 2024

Introduce a new option conntrack-close-wait-time-mills which control how long time before a Connection4 turn into closed state. If too long, new connection with same tgidfd 's data may come into old connection event stream or syscall data buffer, cause negative time. Set it to a relatively small value will prevent this situation. (change 1s to 100ms(default))

fix: #154

introduce a new option `conntrack-close-wait-time-mills` which control how long time before a
connection turn into `closed` state. If too long, new connection with same tgidfd 's data may come
into old connection  event stream or syscall data buffer. Set it  to a relatively small value  will
prevent  this situation.
Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kyanos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 6:56pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug-fix this pr fix a bug labels Dec 24, 2024
Copy link

cloudflare-workers-and-pages bot commented Dec 24, 2024

Deploying kyanos with  Cloudflare Pages  Cloudflare Pages

Latest commit: 335cb69
Status: ✅  Deploy successful!
Preview URL: https://9ba799f1.kyanos.pages.dev
Branch Preview URL: https://fix-negative-time.kyanos.pages.dev

View logs

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Deploying kyanos with  Cloudflare Pages  Cloudflare Pages

Latest commit: 335cb69
Status:⚡️  Build in progress...

View logs

@hengyoush hengyoush merged commit 7a4c410 into main Dec 24, 2024
16 checks passed
@hengyoush hengyoush deleted the fix-negative-time branch December 24, 2024 19:11
hengyoush added a commit that referenced this pull request Jan 6, 2025
* fix(stat): elapsed time is negative

introduce a new option `conntrack-close-wait-time-mills` which control how long time before a
connection turn into `closed` state. If too long, new connection with same tgidfd 's data may come
into old connection  event stream or syscall data buffer. Set it  to a relatively small value  will
prevent  this situation.

* fix: add missing argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix this pr fix a bug size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time calculation incorrect
2 participants