Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdventureMode stopper #334

Merged
merged 8 commits into from
Jul 23, 2023

Conversation

YellowRoseCx
Copy link

@YellowRoseCx YellowRoseCx commented Apr 22, 2023

Stops at "> You " and "You:" when adventure mode is enabled

Was useful for me

@henk717
Copy link
Owner

henk717 commented Apr 22, 2023

I think this will be useful but since it touches the backend I am going to put this on hold until the backend changes are in.

Aquilae00 pushed a commit to Aquilae00/KoboldAI that referenced this pull request Apr 25, 2023
@YellowRoseCx YellowRoseCx force-pushed the YellowRoseCx-advpatch-1 branch 2 times, most recently from 25f8d5f to f863d5d Compare June 15, 2023 20:30
adds a stopper token for adventure mode when it detects the bot generating impersonating text after " > You"
@YellowRoseCx YellowRoseCx reopened this Jun 15, 2023
@YellowRoseCx
Copy link
Author

modified for new backend

@henk717
Copy link
Owner

henk717 commented Jul 19, 2023

Adventure mode responses can be more dynamic, we don't want to block You on a new line because thats what Skein often does.
Simply stopping at > is enough since thats what the UI cleanup code does.

@YellowRoseCx
Copy link
Author

YellowRoseCx commented Jul 19, 2023

Adventure mode responses can be more dynamic, we don't want to block You on a new line because thats what Skein often does. Simply stopping at > is enough since thats what the UI cleanup code does.

The reason I added You is because I was having several models continue on with choices , generating output as me, because it didn't have > in front of it. When I was testing it, I couldn't think of a scenario where this would break normal play

@henk717
Copy link
Owner

henk717 commented Jul 19, 2023

Traditional adventure models like AI Dungeon's model have an extreme You bias.

> You kill the dragon
You step towards the dragon with your sword and cut off its head.

A proper adventure mode basically interperates your instruction and does a varient off it.

@YellowRoseCx
Copy link
Author

YellowRoseCx commented Jul 19, 2023

Traditional adventure models like AI Dungeon's model have an extreme You bias.

> You kill the dragon
You step towards the dragon with your sword and cut off its head.

Yeah that would still work, before it would be like:

> You kill the dragon
You step towards the dragon with your sword and cut off its head. 

You cut off its skin and pack it away in its bag before leaving the cave. Outside the cave you see a man in the distance who saw you kill the dragon.

You shout towards the man and he starts running away

Etc

It's been a while since I last tested this but I believe I tuned it so it will not stop at the first sentence that starts with You because of the stopper having 2 newlines in it

@henk717 henk717 merged commit d704818 into henk717:united Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants