Submit context menu #414
Merged
Submit context menu #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woohooooo back to css - fixes margins to look better - moves contents of context menu items 1px down - fixes context menus near edge wrapping their inner text (ew)
5px was a bit excessive TODO: studied the context menu in my browser for a bit and noticed that if it was going to be too close to the bottom, the browser changes the vertical direction the context menu goes. sounds neat!
I think this would be cool!
Ideas:
- disable/grey when model doesnt support stopping criteria
- shortcuts (maybe, this would def be a power user thing)
- option to generate until EOS token
- option to generate forever until user manually stops
- (not super related but pixels away) make retry while generation is
ongoing cancel generation and retry. same with undo.
too many ideas at once
- adds callback support to `enabledOn` in context menu items - adds `supported_gen_modes` variable for frontend to check if a gen mode is supported - adds `get_supported_gen_modes` to `InferenceModel` to get supported gen modes - takes advantage of cool enum features for less enum-handling code
This mode enables the EOS token and will generate infinitely until hitting it.
...without an entry in `context_menu_items`.
|
Got hit by the other PR's we prioritized. |
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not at main pc so cant make fancy pr with screenshot but right click submit button to see it