Skip to content

Commit

Permalink
GH-125: Fix naming in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
henrikfroehling committed Mar 5, 2020
1 parent d070816 commit bbb31d9
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 24 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ public void Test_TraktPersonMovieCreditsCastItem_Default_Constructor()
}

[Fact]
public async Task Test_TraktPersonMovieCreditsCastItem_From_Minimal_Json()
public async Task Test_TraktPersonMovieCreditsCastItem_From_Json()
{
var jsonReader = new PersonMovieCreditsCastItemObjectJsonReader();
var creditsCastItem = await jsonReader.ReadObjectAsync(MINIMAL_JSON) as TraktPersonMovieCreditsCastItem;
var creditsCastItem = await jsonReader.ReadObjectAsync(JSON) as TraktPersonMovieCreditsCastItem;

creditsCastItem.Should().NotBeNull();
creditsCastItem.Character.Should().Be("Joe Brody");
Expand Down Expand Up @@ -52,7 +52,7 @@ public async Task Test_TraktPersonMovieCreditsCastItem_From_Minimal_Json()
creditsCastItem.Movie.Certification.Should().BeNullOrEmpty();
}

private const string MINIMAL_JSON =
private const string JSON =
@"{
""character"": ""Joe Brody"",
""characters"": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ public void Test_TraktPersonMovieCreditsCrewItem_Default_Constructor()
}

[Fact]
public async Task Test_TraktPersonMovieCreditsCrewItem_From_Minimal_Json()
public async Task Test_TraktPersonMovieCreditsCrewItem_From_Json()
{
var jsonReader = new PersonMovieCreditsCrewItemObjectJsonReader();
var creditsCrewItem = await jsonReader.ReadObjectAsync(MINIMAL_JSON) as TraktPersonMovieCreditsCrewItem;
var creditsCrewItem = await jsonReader.ReadObjectAsync(JSON) as TraktPersonMovieCreditsCrewItem;

creditsCrewItem.Should().NotBeNull();
creditsCrewItem.Job.Should().Be("Director");
Expand Down Expand Up @@ -52,7 +52,7 @@ public async Task Test_TraktPersonMovieCreditsCrewItem_From_Minimal_Json()
creditsCrewItem.Movie.Certification.Should().BeNullOrEmpty();
}

private const string MINIMAL_JSON =
private const string JSON =
@"{
""job"": ""Director"",
""jobs"": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ public void Test_TraktPersonMovieCreditsCrew_Default_Constructor()
}

[Fact]
public async Task Test_TraktPersonMovieCreditsCrew_From_Minimal_Json()
public async Task Test_TraktPersonMovieCreditsCrew_From_Json()
{
var jsonReader = new PersonMovieCreditsCrewObjectJsonReader();
var creditsCrew = await jsonReader.ReadObjectAsync(MINIMAL_JSON) as TraktPersonMovieCreditsCrew;
var creditsCrew = await jsonReader.ReadObjectAsync(JSON) as TraktPersonMovieCreditsCrew;

creditsCrew.Should().NotBeNull();
creditsCrew.Production.Should().NotBeNull().And.HaveCount(2);
Expand Down Expand Up @@ -631,7 +631,7 @@ public async Task Test_TraktPersonMovieCreditsCrew_From_Minimal_Json()
editingCrew[1].Movie.Certification.Should().BeNullOrEmpty();
}

private const string MINIMAL_JSON =
private const string JSON =
@"{
""production"": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ public void Test_TraktPersonMovieCredits_Default_Constructor()
}

[Fact]
public async Task Test_TraktPersonMovieCredits_From_Minimal_Json()
public async Task Test_TraktPersonMovieCredits_From_Json()
{
var jsonReader = new PersonMovieCreditsObjectJsonReader();
var credits = await jsonReader.ReadObjectAsync(MINIMAL_JSON) as TraktPersonMovieCredits;
var credits = await jsonReader.ReadObjectAsync(JSON) as TraktPersonMovieCredits;

credits.Should().NotBeNull();
credits.Cast.Should().NotBeNull().And.HaveCount(2);
Expand Down Expand Up @@ -679,7 +679,7 @@ public async Task Test_TraktPersonMovieCredits_From_Minimal_Json()
editingCrew[1].Movie.Certification.Should().BeNullOrEmpty();
}

private const string MINIMAL_JSON =
private const string JSON =
@"{
""cast"": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ public void Test_TraktPersonShowCreditsCastItem_Default_Constructor()
}

[Fact]
public async Task Test_TraktPersonShowCreditsCastItem_From_Minimal_Json()
public async Task Test_TraktPersonShowCreditsCastItem_From_Json()
{
var jsonReader = new PersonShowCreditsCastItemObjectJsonReader();
var creditsCastItem = await jsonReader.ReadObjectAsync(MINIMAL_JSON) as TraktPersonShowCreditsCastItem;
var creditsCastItem = await jsonReader.ReadObjectAsync(JSON) as TraktPersonShowCreditsCastItem;

creditsCastItem.Should().NotBeNull();
creditsCastItem.Character.Should().Be("Joe Brody");
Expand Down Expand Up @@ -59,7 +59,7 @@ public async Task Test_TraktPersonShowCreditsCastItem_From_Minimal_Json()
creditsCastItem.Show.AiredEpisodes.Should().NotHaveValue();
}

private const string MINIMAL_JSON =
private const string JSON =
@"{
""character"": ""Joe Brody"",
""characters"": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ public void Test_TraktPersonShowCreditsCrewItem_Default_Constructor()
}

[Fact]
public async Task Test_TraktPersonShowCreditsCrewItem_From_Minimal_Json()
public async Task Test_TraktPersonShowCreditsCrewItem_From_Json()
{
var jsonReader = new PersonShowCreditsCrewItemObjectJsonReader();
var creditsCrewItem = await jsonReader.ReadObjectAsync(MINIMAL_JSON) as TraktPersonShowCreditsCrewItem;
var creditsCrewItem = await jsonReader.ReadObjectAsync(JSON) as TraktPersonShowCreditsCrewItem;

creditsCrewItem.Should().NotBeNull();
creditsCrewItem.Job.Should().Be("Director");
Expand Down Expand Up @@ -59,7 +59,7 @@ public async Task Test_TraktPersonShowCreditsCrewItem_From_Minimal_Json()
creditsCrewItem.Show.AiredEpisodes.Should().NotHaveValue();
}

private const string MINIMAL_JSON =
private const string JSON =
@"{
""job"": ""Director"",
""jobs"": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ public void Test_TraktPersonShowCreditsCrew_Default_Constructor()
}

[Fact]
public async Task Test_TraktPersonShowCreditsCrew_From_Minimal_Json()
public async Task Test_TraktPersonShowCreditsCrew_From_Json()
{
var jsonReader = new PersonShowCreditsCrewObjectJsonReader();
var creditsCrew = await jsonReader.ReadObjectAsync(MINIMAL_JSON) as TraktPersonShowCreditsCrew;
var creditsCrew = await jsonReader.ReadObjectAsync(JSON) as TraktPersonShowCreditsCrew;

creditsCrew.Should().NotBeNull();
creditsCrew.Production.Should().NotBeNull().And.HaveCount(2);
Expand Down Expand Up @@ -785,7 +785,7 @@ public async Task Test_TraktPersonShowCreditsCrew_From_Minimal_Json()
editingCrew[1].Show.AiredEpisodes.Should().NotHaveValue();
}

private const string MINIMAL_JSON =
private const string JSON =
@"{
""production"": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ public void Test_TraktPersonShowCredits_Default_Constructor()
}

[Fact]
public async Task Test_TraktPersonShowCredits_From_Minimal_Json()
public async Task Test_TraktPersonShowCredits_From_Json()
{
var jsonReader = new PersonShowCreditsObjectJsonReader();
var credits = await jsonReader.ReadObjectAsync(MINIMAL_JSON) as TraktPersonShowCredits;
var credits = await jsonReader.ReadObjectAsync(JSON) as TraktPersonShowCredits;

credits.Should().NotBeNull();
credits.Cast.Should().NotBeNull().And.HaveCount(2);
Expand Down Expand Up @@ -845,7 +845,7 @@ public async Task Test_TraktPersonShowCredits_From_Minimal_Json()
editingCrew[1].Show.AiredEpisodes.Should().NotHaveValue();
}

private const string MINIMAL_JSON =
private const string JSON =
@"{
""cast"": [
{
Expand Down

0 comments on commit bbb31d9

Please sign in to comment.