GH-346 GH-340: Implement Validate() method for comment post objects

henrikfroehling · Oct 30, 2022 · c8ef5be · c8ef5be
1 parent e1fc5a1
commit c8ef5be
Show file tree

Hide file tree

Showing 7 changed files with 42 additions and 7 deletions.
diff --git a/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktCommentPost.cs b/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktCommentPost.cs
@@ -1,6 +1,8 @@
 namespace TraktNet.Objects.Post.Comments
 {
+    using Extensions;
     using Objects.Basic;
+    using System;
     using System.Threading;
     using System.Threading.Tasks;
 
@@ -21,6 +23,13 @@ public abstract class TraktCommentPost : ITraktCommentPost
 
         public abstract Task<string> ToJson(CancellationToken cancellationToken = default);
 
-        public abstract void Validate();
+        public virtual void Validate()
+        {
+            if (Comment == null)
+                throw new ArgumentNullException(nameof(Comment));
+
+            if (Comment.WordCount() < 5)
+                throw new ArgumentOutOfRangeException(nameof(Comment), "comment has too few words - at least five words are required");
+        }
     }
 }
diff --git a/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktCommentUpdatePost.cs b/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktCommentUpdatePost.cs
@@ -1,6 +1,8 @@
 namespace TraktNet.Objects.Post.Comments
 {
+    using Extensions;
     using Objects.Json;
+    using System;
     using System.Threading;
     using System.Threading.Tasks;
 
@@ -21,7 +23,11 @@ public virtual Task<string> ToJson(CancellationToken cancellationToken = default
 
         public virtual void Validate()
         {
-            // TODO
+            if (Comment == null)
+                throw new ArgumentNullException(nameof(Comment));
+
+            if (Comment.WordCount() < 5)
+                throw new ArgumentOutOfRangeException(nameof(Comment), "comment has too few words - at least five words are required");
         }
     }
 }
diff --git a/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktEpisodeCommentPost.cs b/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktEpisodeCommentPost.cs
@@ -2,6 +2,7 @@
 {
     using Get.Episodes;
     using Objects.Json;
+    using System;
     using System.Threading;
     using System.Threading.Tasks;
 
@@ -22,7 +23,10 @@ public override Task<string> ToJson(CancellationToken cancellationToken = defaul
 
         public override void Validate()
         {
-            // TODO
+            base.Validate();
+
+            if (Episode == null)
+                throw new ArgumentNullException(nameof(Episode));
         }
     }
 }
diff --git a/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktListCommentPost.cs b/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktListCommentPost.cs
@@ -2,6 +2,7 @@
 {
     using Get.Lists;
     using Objects.Json;
+    using System;
     using System.Threading;
     using System.Threading.Tasks;
 
@@ -22,7 +23,10 @@ public override Task<string> ToJson(CancellationToken cancellationToken = defaul
 
         public override void Validate()
         {
-            // TODO
+            base.Validate();
+
+            if (List == null)
+                throw new ArgumentNullException(nameof(List));
         }
     }
 }
diff --git a/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktMovieCommentPost.cs b/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktMovieCommentPost.cs
@@ -2,6 +2,7 @@
 {
     using Get.Movies;
     using Objects.Json;
+    using System;
     using System.Threading;
     using System.Threading.Tasks;
 
@@ -22,7 +23,10 @@ public override Task<string> ToJson(CancellationToken cancellationToken = defaul
 
         public override void Validate()
         {
-            // TODO
+            base.Validate();
+
+            if (Movie == null)
+                throw new ArgumentNullException(nameof(Movie));
         }
     }
 }
diff --git a/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktSeasonCommentPost.cs b/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktSeasonCommentPost.cs
@@ -2,6 +2,7 @@
 {
     using Get.Seasons;
     using Objects.Json;
+    using System;
     using System.Threading;
     using System.Threading.Tasks;
 
@@ -22,7 +23,10 @@ public override Task<string> ToJson(CancellationToken cancellationToken = defaul
 
         public override void Validate()
         {
-            // TODO
+            base.Validate();
+
+            if (Season == null)
+                throw new ArgumentNullException(nameof(Season));
         }
     }
 }
diff --git a/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktShowCommentPost.cs b/Source/Lib/Trakt.NET/Objects/Post/Comments/Implementations/TraktShowCommentPost.cs
@@ -2,6 +2,7 @@
 {
     using Get.Shows;
     using Objects.Json;
+    using System;
     using System.Threading;
     using System.Threading.Tasks;
 
@@ -22,7 +23,10 @@ public override Task<string> ToJson(CancellationToken cancellationToken = defaul
 
         public override void Validate()
         {
-            // TODO
+            base.Validate();
+
+            if (Show == null)
+                throw new ArgumentNullException(nameof(Show));
         }
     }
 }