Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return same instance type for people requests in Episodes, Shows and Seasons module #185

Closed
mpfc75 opened this issue Sep 11, 2020 · 0 comments · Fixed by #190
Closed

Return same instance type for people requests in Episodes, Shows and Seasons module #185

mpfc75 opened this issue Sep 11, 2020 · 0 comments · Fixed by #190
Labels
Improvement Library Module Episodes Module People Module Seasons Module Shows Target-Branch: release-1.1.0 v1.1.0
Milestone
Version 1.1.0

Comments

@mpfc75
Copy link

mpfc75 commented Sep 11, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
The methods

  • client.Shows.GetShowPeopleAsync
  • client.Seasons.GetSeasonPeopleAsync

both return ITraktShowCastAndCrew

while method

  • client.Episodes.GetEpisodePeopleAsync

returns ITraktCastAndCrew

Describe the solution you'd like
For consistency, could all three similar methods return the same instance (perhaps they could all return ITraktCastAndCrew).

Occurring in Trakt.NET version 1.0.2
@henrikfroehling henrikfroehling added this to the Version 1.1.0 milestone Sep 13, 2020
@henrikfroehling henrikfroehling changed the title Methods GetXXXPeopleAsync return different instance types. Could they return the same type? Return same instance type for people requests in Episodes, Shows and Seasons module Sep 13, 2020
@henrikfroehling henrikfroehling mentioned this issue Sep 13, 2020
Closed
40 tasks
@skyfrk skyfrk mentioned this issue Oct 1, 2020
Merged
henrikfroehling added a commit that referenced this issue Oct 1, 2020
@henrikfroehling
Merge pull request #190 from skyfrk/issue-185
63f6ccb 
Resolves GH-185
@henrikfroehling henrikfroehling removed their assignment Oct 1, 2020
@henrikfroehling henrikfroehling moved this to Done in Trakt.NET Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Library Module Episodes Module People Module Seasons Module Shows Target-Branch: release-1.1.0 v1.1.0
Projects
Trakt.NET
Status: Done
Milestone
Version 1.1.0
Development

Successfully merging a pull request may close this issue.

Return same instance type for people requests in Episodes, Shows and Seasons module
2 participants
@henrikfroehling @mpfc75