Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar methods do not accept a value greater than 31 for days #220

Closed
mpfc75 opened this issue Feb 20, 2021 · 1 comment · Fixed by #226
Closed

Calendar methods do not accept a value greater than 31 for days #220

mpfc75 opened this issue Feb 20, 2021 · 1 comment · Fixed by #226

Comments

@mpfc75
Copy link

mpfc75 commented Feb 20, 2021

The Trakt calendars/my/shows/start_date/days API allows for days <= 33. Trakt.Net GetUserShowsAsync throws error if days>31.

System.ArgumentOutOfRangeException Message=days must have a value between 1 and 31 Parameter name: Days

I believe Trakt has recently increased this limit from 31.

Postman call api.trakt.tv/calendars/my/shows/2021-03-01/33 returns shows from 2021-03-01 to 2021-04-02.

FYI, changing the days in Postman to a larger number (e.g., 100) will result in a status code 200 but the data returned still ends at 2021-04-02 (33 days).

The above is also true of calendars/all/shows/new/start_date/days and GetAllNewShowsAsync.

Occurs in Trakt.Net v1.1.0

@henrikfroehling
Copy link
Owner

@mpfc75
I looked at the documentation. It says the maximum is 33 days. But since higher values also return a successful status code, I might consider removing this check completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment