Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetShowAsync returns Status null when status is 'planned' #221

Closed
mpfc75 opened this issue Mar 15, 2021 · 5 comments · Fixed by #225
Closed

GetShowAsync returns Status null when status is 'planned' #221

mpfc75 opened this issue Mar 15, 2021 · 5 comments · Fixed by #225

Comments

@mpfc75
Copy link

mpfc75 commented Mar 15, 2021

This is a variation of issue "GetShowAsync returns Status null when status is 'upcoming' #208".

Calls to GetShowAsync (v1.1.0) returns status=null for shows in Trakt with a status of 'planned' (for example home-economics).

Postman shows 'planned' for the show home-economics.

(It seems Trakt isn't keeping their documentation current with the API. So far, we have seen undocumented status of upcoming and planned. I wonder if there are more?)

@henrikfroehling
Copy link
Owner

@mpfc75
Good catch. I already created an issue if there are more values missing in the documentation.

I might consider a bugfix release for version 1.1.0 in the next couple of days.

@mpfc75
Copy link
Author

mpfc75 commented Mar 15, 2021

Yes, I did see your issue with Trakt but I also see that they haven't replied yet. It occurred to me that with their move away from TVDB to using TMDB exclusively that TMDB may be the source of the 'bad data'. I checked the show there and sure enough the status is "Planned" (capital P). But reviewing the TMDB Contribution Bible https://www.themoviedb.org/bible/tv upcoming and planned are not listed as valid. So I don't know how it is getting thru.

@henrikfroehling
Copy link
Owner

I don't know what's exactly wrong with the data or not, but I added the value to the status so it gets accepted in future versions.

@henrikfroehling
Copy link
Owner

@mpfc75 A new version 1.1.1 is on Nuget.

@mpfc75
Copy link
Author

mpfc75 commented Mar 17, 2021

@henrikfroehling Thanks Henrik! v1.1.1 seems to resolve the three issues I reported (at least the calendar days and status=planned. I don't have a show at the moment that has a status=upcoming but I'm confident it will work too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment