Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: #632 #633 #634 #635 #636 - Add support for new notes requests #637

Merged
merged 10 commits into from
Apr 20, 2024

Conversation

henrikfroehling
Copy link
Owner

No description provided.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 87.98799% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 77.58%. Comparing base (fbcf5dc) to head (a1cf261).

❗ Current head a1cf261 differs from pull request most recent head 00747a9. Consider uploading reports for the commit 00747a9 to get more accurate results

Files Patch % Lines
...rakt.NET/Modules/Notes/TraktNotesModule_AddNote.cs 88.65% 11 Missing and 11 partials ⚠️
...Post/Notes/Json/Reader/NotePostObjectJsonReader.cs 81.81% 4 Missing and 2 partials ⚠️
...Post/Notes/Json/Writer/NotePostObjectJsonWriter.cs 93.02% 2 Missing and 1 partial ⚠️
...otes/Json/Factories/NoteAttachedToJsonIOFactory.cs 0.00% 2 Missing ⚠️
.../Get/Notes/Json/Writer/NoteItemObjectJsonWriter.cs 0.00% 2 Missing ⚠️
.../Get/Notes/Json/Factories/NoteItemJsonIOFactory.cs 50.00% 1 Missing ⚠️
...ects/Get/Notes/Json/Factories/NoteJsonIOFactory.cs 50.00% 1 Missing ⚠️
...otes/Json/Reader/NoteAttachedToObjectJsonReader.cs 50.00% 1 Missing ⚠️
...ects/Get/Notes/Json/Reader/NoteObjectJsonReader.cs 50.00% 1 Missing ⚠️
...Post/Notes/Json/Factories/NotePostJsonIOFactory.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.4.0     #637      +/-   ##
=================================================
+ Coverage          77.40%   77.58%   +0.18%     
=================================================
  Files               1584     1592       +8     
  Lines              26348    26660     +312     
  Branches            5734     5760      +26     
=================================================
+ Hits               20394    20685     +291     
- Misses              5568     5575       +7     
- Partials             386      400      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Add notes module implementation for adding notes
Copy link

@henrikfroehling henrikfroehling merged commit daf5f4c into release-1.4.0 Apr 20, 2024
10 checks passed
@henrikfroehling henrikfroehling deleted the issue/release-1.4.0/notes-support branch April 20, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment