Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n & linux command copy #233

Merged
merged 4 commits into from
Oct 29, 2024
Merged

i18n & linux command copy #233

merged 4 commits into from
Oct 29, 2024

Conversation

ArsFy
Copy link
Contributor

@ArsFy ArsFy commented Oct 29, 2024

  1. i18n support:
    • DE
    • EN
    • ES
    • FR
    • RU
    • zh-CN
    • zh-HK
  2. Add new system: Binary (linux command)
  3. Windows: Ctrl K

@henrygd
Copy link
Owner

henrygd commented Oct 29, 2024

Amazing, thank you so much!

It's 10pm where I am so I'll check this out tomorrow. Possibly not until the afternoon.

@henrygd henrygd merged commit e64fad9 into henrygd:main Oct 29, 2024
@henrygd
Copy link
Owner

henrygd commented Oct 29, 2024

@ArsFy I really appreciate this. That was a lot of work and I'm extremely thankful.

We have a few areas still to translate, but they are minor and don't necessarily need to be done now.

Thanks for setting up the project on Crowdin. I'm fine with you owning the project if you want to, or you can transfer it to me if you don't want it to count against your account limits. I need to be added as an admin or manager, though.

Alternatively, we can move to Weblate and I can invite you as an admin. That would give us higher limits. Seems to be compatible with the current setup as well.

Edit: Maybe it's easiest to stick with Crowdin for now and move to Weblate if we near our free plan limits.

@ArsFy
Copy link
Contributor Author

ArsFy commented Oct 30, 2024

@henrygd Okay, let's move the project to Weblate. However, there is a link to Crowdin in general.tsx:53 that needs to be changed after the project is moved.

My Weblate username is @ArsFy

@henrygd
Copy link
Owner

henrygd commented Oct 30, 2024

@ArsFy Just added you as an admin on Weblate.

The stuff in there currently is a test scan I did on the repo.

I think we'll need to delete it and rescan after we get the fresh translations from Crowdin added to the repo.

Including the Ukrainian translations from @alexzaitsev (thank you!).

@ArsFy
Copy link
Contributor Author

ArsFy commented Oct 30, 2024

@henrygd I will directly delete the Crowdin project. The latest translations are actually in my repo, and I have added some features. I will create a new merge request to add the new features (note that I haven't modified the links pointing to Crowdin in the code, you might need to do that as I forgot about it)

If he can provide the Ukrainian translation, that would be great. Please upload it to the new Weblate project, and I will take care of the rest.

@ArsFy
Copy link
Contributor Author

ArsFy commented Oct 30, 2024

@henrygd In fact, I have never used Weblate before. If I modify the JSON in the repo, will Weblate automatically update? 🤔

@henrygd
Copy link
Owner

henrygd commented Oct 30, 2024

@ArsFy Looks like it can: https://docs.weblate.org/en/latest/admin/continuous.html#automatically-receiving-changes-from-github

I need to set that up, which will be tomorrow at earliest because it's lat here.

I think you can manually pull changes for now. We should just delete what I have in there and start over.

@henrygd
Copy link
Owner

henrygd commented Oct 30, 2024

@ArsFy FYI - I just pushed Japanese, Vietnamese, and Arabic (need to check RTL) to the repo.

Alex added Ukrainian translations to Crowdin but I didn't grab them before the project was deleted.

@ArsFy
Copy link
Contributor Author

ArsFy commented Oct 30, 2024

@henrygd He added it to crowdin? I'm really sorry that this is my problem. I didn't confirm whether any translation was added. I hope he has a copy of the translation 😭

@henrygd
Copy link
Owner

henrygd commented Oct 30, 2024

@ArsFy Don't sweat it, they can always be recreated.

@alexzaitsev Any chance you saved a local copy of your translations?

@alexzaitsev
Copy link

alexzaitsev commented Oct 30, 2024

LOL guys I haven't saved it locally!
I thought it's a great project to contribute but you won't get too far just discarding other people's work.

@alexzaitsev
Copy link

I was working on #219 btw. I see it's fixed in this release. Is there any assignment mechanism so I can assign the bug I'm working on to myself?

@henrygd
Copy link
Owner

henrygd commented Oct 30, 2024

@alexzaitsev Our apologies. I can understand your frustration. We hadn't finalized what platform we were going to use for localization, and ArsFy didn't know that I'd shared the preview site with anyone else.

It's regrettable, but the mistake was due to miscommunication and not malice. We'll add machine translations for Ukrainian to start with. That way it doesn't need to be translated from scratch if someone wants to improve them.


I agree that it should be clearer what work is completed or in progress. I've created an "in progress" label that I'll start adding to issues which are being worked on. I'll also try to be more proactive about including issue tags in commit messages and closing issues when development is done.

For you and others, I think the best thing to do is make a comment in the issue saying "I'll try to work on this" or something like that. Then I can also assign it to you.

If it's not assigned to anyone, and not clear from the context who will work on it, it will be me eventually.

@ArsFy
Copy link
Contributor Author

ArsFy commented Oct 31, 2024

I'm very, very sorry @alexzaitsev, I thought the Crowdin project had not been shared. I understand that several hours of work are very important to you, and I highly value others' work. Please allow me to apologize once again.

I don’t speak Ukrainian, so I have no way to complete this part with high quality. However, I would like to make it up to you. I’m not sure what I can do, but please let me know if there’s anything I can help with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants