Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README #1

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Add README #1

merged 1 commit into from
Aug 8, 2017

Conversation

kensimon
Copy link
Contributor

@kensimon kensimon commented Aug 8, 2017

No description provided.

@kensimon
Copy link
Contributor Author

kensimon commented Aug 8, 2017

@timothysc @abiogenesis-now @chuckha

@kensimon kensimon requested a review from jesscodez August 8, 2017 21:28
Copy link

@jesscodez jesscodez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes then LGTM

README.md Outdated
@@ -0,0 +1,5 @@
# Kubernetes conformance tests

This is a standalone container able to launch kubernetes end-to-end tests, for the purposes of conformance testing.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: capitalize Kubernetes

README.md Outdated

This is a standalone container able to launch kubernetes end-to-end tests, for the purposes of conformance testing.

It is only a thin wrapper around the `e2e.test` binary in the upstream kubernetes distribution, which drops results in a predetermined location for use as a [sonobuoy](https://github.com/heptio/sonobuoy) plugin.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/sonobuoy/Heptio Sonobuoy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also add one more sentence:

To learn more about conformance testing and its Sonobuoy integration, read the conformance guide.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: remove word "only", capitalize Kubernetes

@kensimon kensimon merged commit 63f9c72 into heptio:master Aug 8, 2017
@kensimon kensimon deleted the readme branch August 8, 2017 21:46
bzub pushed a commit to cloudnativelabs/kube-conformance that referenced this pull request Aug 21, 2017
Update bootkube assets for v0.4.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants