Support building images with a provided k8s version #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other enhancements:
- Pre-determine if sudo is needed for docker commands
- Copy kubernetes/cluster into image to support more non-conformance e2e
tests (tested with E2E_FOCUS="Feature:NetworkPolicy")
So now make {container,push} KUBE_VERSION=1.X, etc will get the latest
1.X.Y version of k8s in that minor release range and tag images with
"latest", "v1.X", and "v1.X.Y".
For example, right now v1.7 minor version. When v1.8 is considered stable, change "latest_stable = 1.8"
timothysc
reviewed
Sep 1, 2017
| @@ -14,8 +14,8 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| echo "/usr/local/bin/e2e.test --ginkgo.skip=\"${E2E_SKIP}\" --ginkgo.focus=\"${E2E_FOCUS}\" --provider=\"${E2E_PROVIDER}\" --report-dir=\"${RESULTS_DIR}\" --ginkgo.noColor=true" | |||
| /usr/local/bin/e2e.test --ginkgo.skip="${E2E_SKIP}" --ginkgo.focus="${E2E_FOCUS}" --provider="${E2E_PROVIDER}" --report-dir="${RESULTS_DIR}" --ginkgo.noColor=true | tee ${RESULTS_DIR}/e2e.log | |||
| echo "/usr/local/bin/e2e.test --repo-root=/kubernetes --ginkgo.skip=\"${E2E_SKIP}\" --ginkgo.focus=\"${E2E_FOCUS}\" --provider=\"${E2E_PROVIDER}\" --report-dir=\"${RESULTS_DIR}\" --ginkgo.noColor=true" | |||
There was a problem hiding this comment.
Is repo-root added back somehow as a hard dep in the tests? We spent a lot of time sifting through removing those deps year+ ago.
|
Are you all running the builds on LInux systems directly? The current implementation of Outside of taking manual steps, I didn't see an easy way to modify the Makefile configs to have an easy path to install. |
|
@bzub if you could squash the commits and explain the need for repo-root I'd be happy to merge. Sorry for the delay I was out for a while. |
|
I'm just going to merge and run through a full update once 1.8-beta2 is cut tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other enhancements:
tests (tested with E2E_FOCUS="Feature:NetworkPolicy")
So now make {container,push} KUBE_VERSION=1.X, etc will get the latest
1.X.Y version of k8s in that minor release range and tag images with
"latest", "v1.X", and "v1.X.Y".