Merge pull request #19 from herbie-fp/trig-tuning-fix

Formula change for input reduction in trig functions
herbie-fp · Mar 12, 2024 · 16a5f5c · 16a5f5c
2 parents a45489c + 05866cf
commit 16a5f5c
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/main.rkt b/main.rkt
@@ -599,9 +599,9 @@
     ['range-reduce
      (let ([prec (min (*rival-precision*)
                       (max (bf-precision)
-                           (+ 10 (max
-                                  (+ (bigfloat-exponent xlo) (bigfloat-precision xlo))
-                                  (+ (bigfloat-exponent xhi) (bigfloat-precision xhi))))))])
+                           (max
+                            (+ (bigfloat-exponent xlo) (bigfloat-precision xlo) (bigfloat-precision xlo))
+                            (+ (bigfloat-exponent xhi) (bigfloat-precision xhi) (bigfloat-precision xhi)))))])
        (match-define (ival (endpoint a _) (endpoint b _) _ _)
          (parameterize ([bf-precision prec])
            (ival-floor (ival-div x (ival-pi)))))
@@ -629,9 +629,9 @@
     ['range-reduce
      (let ([prec (min (*rival-precision*)
                       (max (bf-precision)
-                           (+ 10 (max
-                                  (+ (bigfloat-exponent xlo) (bigfloat-precision xlo))
-                                  (+ (bigfloat-exponent xhi) (bigfloat-precision xhi))))))])
+                           (max
+                            (+ (bigfloat-exponent xlo) (bigfloat-precision xlo) (bigfloat-precision xlo))
+                            (+ (bigfloat-exponent xhi) (bigfloat-precision xhi) (bigfloat-precision xhi)))))])
        (match-define (ival (endpoint a _) (endpoint b _) _ _)
          (parameterize ([bf-precision prec])
            (ival-round (ival-div x (ival-pi)))))
@@ -662,9 +662,9 @@
     ['range-reduce
      (let ([prec (min (*rival-precision*)
                       (max (bf-precision)
-                           (+ 10 (max
-                                  (+ (bigfloat-exponent xlo) (bigfloat-precision xlo))
-                                  (+ (bigfloat-exponent xhi) (bigfloat-precision xhi))))))])
+                           (max
+                            (+ (bigfloat-exponent xlo) (bigfloat-precision xlo) (bigfloat-precision xlo))
+                            (+ (bigfloat-exponent xhi) (bigfloat-precision xhi) (bigfloat-precision xhi)))))])
        (match-define (ival (endpoint a _) (endpoint b _) _ _)
          (parameterize ([bf-precision prec])
            (ival-round (ival-div x (ival-pi)))))