Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.js: Removed declared constant without use #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

index.js: Removed declared constant without use #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a39a240
index.js: Remove declared constants without use
toyamarodrigo Oct 26, 2023
2818213
CONTRIBUTING.md: Update markdown
toyamarodrigo Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
# Introduction
# Contributing to the Flexible Polyline Project

## Introduction

The team behind the [Flexible Polyline](https://github.com/heremaps/flexible-polyline) gratefully accepts contributions via
[pull requests](https://help.github.com/articles/about-pull-requests/) filed against the
[GitHub project](https://github.com/heremaps/flexible-polyline/pulls).

# Signing each Commit
## Signing each Commit

As part of filing a pull request we ask you to sign off the
[Developer Certificate of Origin](https://developercertificate.org/) (DCO) in each commit.
Expand All @@ -17,12 +19,14 @@ to indicate that you agree with the DCO.

An example signed commit message:

```
README.md: Fix minor spelling mistake
```txt
README.md: Fix minor spelling mistake

Signed-off-by: John Doe <john.doe@example.com>
Signed-off-by: John Doe <john.doe@example.com>
```

Git has the `-s` flag that can sign a commit for you, see example below:

`$ git commit -s -m 'README.md: Fix minor spelling mistake'`
```sh
git commit -s -m 'README.md: Fix minor spelling mistake'
```
3 changes: 0 additions & 3 deletions javascript/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ const LEVEL = 1;
const ALTITUDE = 2;
const ELEVATION = 3;
// Reserved values 4 and 5 should not be selectable
const CUSTOM1 = 6;
const CUSTOM2 = 7;

const Num = typeof BigInt !== "undefined" ? BigInt : Number;

Expand Down Expand Up @@ -195,7 +193,6 @@ function encodeScaledValue(value) {
module.exports = {
encode,
decode,

ABSENT,
LEVEL,
ALTITUDE,
Expand Down
2 changes: 1 addition & 1 deletion javascript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@here/flexpolyline",
"version": "0.1.0",
"version": "0.1.1",
"description": "Flexible Polyline encoding: a lossy compressed representation of a list of coordinate pairs or triples",
"main": "index.js",
"scripts": {
Expand Down