Improve testability of structs in Dart #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielKamkha
force-pushed
the
dart-testable-struct-methods
branch
from
fe50441 to
38557ca
Compare
Updated DartStruct template to improve testability: updated instance methods to be redirects to `$prototype`, similarly to how it's done already for static methods. Updated smoke tests. Functional tests don't need to be updated because there is no change in user-facing functionality. Resolves: #1028 Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha
force-pushed
the
dart-testable-struct-methods
branch
from
38557ca to
f6ad127
Compare
michal1459
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated DartStruct template to improve testability: updated instance methods to be redirects to
$prototype, similarly to howit's done already for static methods.
Updated smoke tests. Functional tests don't need to be updated because there is
no change in user-facing functionality.
Resolves: #1028
Signed-off-by: Daniel Kamkha daniel.kamkha@here.com