AAA-24174 Support proxy for HereAccessTokenProvider #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishKhushiKumar
force-pushed
the
AAAA-24174
branch
from
9169613 to
96e8bd5
Compare
owenkellett
reviewed
Sep 10, 2024
here-oauth-client/src/main/java/com/here/account/http/apache/ApacheHttpClientProvider.java
Show resolved
Hide resolved
here-oauth-client/src/main/java/com/here/account/http/apache/ApacheHttpClientProvider.java
Outdated
Show resolved
Hide resolved
...-example/src/main/java/com/here/account/oauth2/tutorial/HereAccessTokenProviderTutorial.java
Show resolved
Hide resolved
spaltis
reviewed
Sep 10, 2024
There was a problem hiding this comment.
@ashishKhushiKumar Will you be adding a test utilizing proxy server?
ashishKhushiKumar
force-pushed
the
AAAA-24174
branch
from
96e8bd5 to
3c75322
Compare
ashishKhushiKumar
force-pushed
the
AAAA-24174
branch
8 times, most recently
from
a01d1cb to
b84eea6
Compare
owenkellett
approved these changes
Sep 26, 2024
spaltis
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
@ashishKhushiKumar Thank you for addressing comments. LGTM.
Signed-off-by: ashikuma <ashish.kumar@here.com>
ashishKhushiKumar
force-pushed
the
AAAA-24174
branch
from
b84eea6 to
9145752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashish Kumar ashish.kumar@here.com